Skip to content

Commit 33c0345

Browse files
committed
Move skip to the point of failure
1 parent e8cd2bf commit 33c0345

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

xds/internal/balancer/clusterimpl/tests/balancer_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,6 @@ func (s) TestConfigUpdateWithSameLoadReportingServerConfig(t *testing.T) {
183183
// when using pickfirst with endpoints in multiple localities.
184184
func (s) TestLoadReportingPickFirstMultiLocality(t *testing.T) {
185185
// TODO(#7339): Enable this test once pickfirst has one address per subconn.
186-
t.Skip("Skipping due to issue #7339.")
187186
originalTickerFactory := transport.TickerFactory
188187
tickChan := make(chan time.Time)
189188
transport.TickerFactory = func(freq time.Duration) (<-chan time.Time, func()) {
@@ -379,6 +378,7 @@ func (s) TestLoadReportingPickFirstMultiLocality(t *testing.T) {
379378
}
380379

381380
if finalRegion == initialRegion {
381+
t.Skip("Skipping due to issue #7339.")
382382
t.Errorf("Unexpected region received traffic: %q", finalRegion)
383383
}
384384
}

0 commit comments

Comments
 (0)