address comments

Author: printchard

internal/transport/grpchttp2/errors.go

@@ -18,6 +18,8 @@
 
 package grpchttp2
 
+import "fmt"
+
 // ErrCode represents an HTTP/2 Error Code. Error codes are 32-bit fields
 // that are used in [RST_STREAM] and [GOAWAY] frames to convey the reasons for
 // the stream or connection error. See [HTTP/2 Error Code] for definitions of
@@ -66,5 +68,5 @@ func (err ErrCode) String() string {
 	if v, ok := errorCodeNames[err]; ok {
 		return v
 	}
-	return "INTERNAL_ERROR"
+	return fmt.Sprintf("unknown error code 0x%x", uint32(err))
 }

internal/transport/grpchttp2/framer.go

@@ -30,10 +30,8 @@ type FrameType uint8
 const (
 	FrameTypeData         FrameType = 0x0
 	FrameTypeHeaders      FrameType = 0x1
-	FrameTypePriority     FrameType = 0x2
 	FrameTypeRSTStream    FrameType = 0x3
 	FrameTypeSettings     FrameType = 0x4
-	FrameTypePushPromise  FrameType = 0x5
 	FrameTypePing         FrameType = 0x6
 	FrameTypeGoAway       FrameType = 0x7
 	FrameTypeWindowUpdate FrameType = 0x8
@@ -101,6 +99,9 @@ type FrameHeader struct {
 // Frame represents an HTTP/2 Frame.
 type Frame interface {
 	Header() *FrameHeader
+	// Free frees the underlying buffer if present so it can be reused by the
+	// framer.
+	Free()
 }
 
 type DataFrame struct {
@@ -144,16 +145,19 @@ func (f *RSTStreamFrame) Header() *FrameHeader {
 	return f.hdr
 }
 
+func (f *RSTStreamFrame) Free() {}
+
 type SettingsFrame struct {
 	hdr      *FrameHeader
-	free     func()
 	settings []Setting
 }
 
 func (f *SettingsFrame) Header() *FrameHeader {
 	return f.hdr
 }
 
+func (f *SettingsFrame) Free() {}
+
 type PingFrame struct {
 	hdr  *FrameHeader
 	free func()
@@ -225,7 +229,9 @@ func (f *MetaHeadersFrame) Header() *FrameHeader {
 	return f.hdr
 }
 
-// Framer represents a Framer used in gRPC-Go.
+func (f *MetaHeadersFrame) Free() {}
+
+// Framer encapsulates the functionality to read and write HTTP/2 frames.
 type Framer interface {
 	// SetMetaDecoder will set a decoder for the framer. When the decoder is
 	// set, ReadFrame will parse the header values, merging all Headers and