ci: fix jest/cypress clash that broke eslint locally

Author: acao

.eslintrc.js

@@ -5,9 +5,12 @@
  *  This source code is licensed under the license found in the
  *  LICENSE file in the root directory of this source tree.
  *
- *  @flow
  */
 
+const defaultPlugins = ['babel', 'import', 'flowtype', 'prefer-object-spread'];
+
+const defaultPresets = ['prettier', 'plugin:import/typescript', 'plugin:react/recommended'];
+
 module.exports = {
   root: true,
   parser: 'babel-eslint',
@@ -21,9 +24,9 @@ module.exports = {
     },
   },
   settings: {
-    'react': {
-      'version': 'detect'
-    }
+    react: {
+      version: 'detect',
+    },
   },
   // https://github.com/sindresorhus/globals/blob/master/globals.json
   env: {
@@ -33,10 +36,9 @@ module.exports = {
     jest: true,
     mocha: true,
     browser: true,
-    'cypress/globals': true
   },
 
-  extends: ['prettier', 'plugin:import/typescript', 'plugin:react/recommended'],
+  extends: defaultPresets,
 
   globals: {
     atom: false,
@@ -292,9 +294,19 @@ module.exports = {
     'prefer-object-spread/prefer-object-spread': 1,
   },
 
-  plugins: ['babel', 'import', 'flowtype', 'prefer-object-spread', 'cypress'],
+  plugins: defaultPlugins,
 
   overrides: [
+    // Cypress plugin, global, etc only for cypress directory
+    // https://github.com/cypress-io/eslint-plugin-cypress
+    // cypress clashes with jest expect()
+    {
+      files: ['**/cypress/**'],
+      plugins: [...defaultPlugins, 'cypress'],
+      env: {
+        'cypress/globals': true,
+      },
+    },
     // Rules for TypeScript only
     {
       files: ['*.ts', '*.tsx'],