Skip to content

Stringify path if Rails version > 7#107

Merged
jkeen merged 5 commits intographiti-api:masterfrom
sideshowbandana:bug/route_lookup
Mar 18, 2025
Merged

Stringify path if Rails version > 7#107
jkeen merged 5 commits intographiti-api:masterfrom
sideshowbandana:bug/route_lookup

Conversation

@sideshowbandana
Copy link
Copy Markdown
Contributor

Calling recognize_path with a path that is a symbol will result in a:

NoMethodError: undefined method `include?' for an instance of Symbol

This results in a nil value being returned which leads to this error for the developer:

Graphiti::Errors::InvalidLink:
  Api::V2::GymResource: Cannot link to sideload :my_resource!

  Make sure the endpoint "/api/v2/my_resource" exists with action :index, or customize the endpoint for Api::V2::MyResource.

  If you do not wish to generate a link, pass link: false or set
  self.autolink = false.

Calling recognize_path with a path that is a symbol will result in a:

```
NoMethodError: undefined method `include?' for an instance of Symbol
```

This results in a nil value being returned which leads to this error
for the developer:

```
Graphiti::Errors::InvalidLink:
  Api::V2::GymResource: Cannot link to sideload :my_resource!

  Make sure the endpoint "/api/v2/my_resource" exists with action :index, or customize the endpoint for Api::V2::MyResource.

  If you do not wish to generate a link, pass link: false or set
  self.autolink = false.
```
@wagenet
Copy link
Copy Markdown
Collaborator

wagenet commented Jan 12, 2024

@sideshowbandana I changed jobs a while back and am no longer working with Rails. If you, or anyone you know, are interested in helping maintain this project please let me know.

@factyy
Copy link
Copy Markdown

factyy commented Jan 29, 2024

@wagenet , sorry to interrupt your discussion but wanted to ask whether you mean interested in maintaining this particular gem or the whole Graphiti project?

@jkeen jkeen merged commit 47d356c into graphiti-api:master Mar 18, 2025
1 check passed
@sideshowbandana
Copy link
Copy Markdown
Contributor Author

👍

@jkeen
Copy link
Copy Markdown
Collaborator

jkeen commented Mar 18, 2025

@sideshowbandana Thanks for the PR. I've been the skeleton crew maintaining graphiti for the past year, but I'm still waiting on getting access to this gem, so I can't cut a new release quite yet. But I'm working on it.

github-actions Bot pushed a commit that referenced this pull request Mar 21, 2025
## [0.4.1](v0.4.0...v0.4.1) (2025-03-21)

### Bug Fixes

* `register_parameter_parser` overiding custom config ([#109](#109)) ([a135bfa](a135bfa))
* Add basic column type conversion. ([#83](#83)) ([e5bbc92](e5bbc92))
* Add condition to check RSpec availability in install generator ([#63](#63)) ([13895d9](13895d9))
* rspec double was leaking across tests ([#105](#105)) ([b38faf2](b38faf2))
* Stringify path if Rails version > 7 ([#107](#107)) ([47d356c](47d356c))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 0.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants