Skip to content

Conversation

@jackw
Copy link
Contributor

@jackw jackw commented Nov 7, 2025

This PR makes the cp-update workflow token input required to convince plugin developers to pass a PAT. We need this to resolve permission issues now create-plugin update can touch workflow files.

See associated plugin-tools PR here.

@jackw jackw self-assigned this Nov 7, 2025
@jackw jackw requested review from a team as code owners November 7, 2025 09:50
@jackw jackw requested review from academo and hugohaggmark and removed request for oshirohugo November 7, 2025 09:56
@grafana-plugins-platform-bot grafana-plugins-platform-bot bot moved this from 📬 Triage to 🔬 In review in Plugins Platform / Grafana Community Nov 7, 2025
Comment on lines 35 to 39
<<<<<<< Updated upstream
=======
with:
token: ${{ secrets.GH_PAT_TOKEN }}
>>>>>>> Stashed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad merge here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed in 29322d0

@jackw jackw merged commit d198906 into main Nov 13, 2025
6 checks passed
@jackw jackw deleted the jackw/cp-update-token branch November 13, 2025 08:19
@github-project-automation github-project-automation bot moved this from 🔬 In review to 🚀 Shipped in Plugins Platform / Grafana Community Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants