Fix cell selection when using shift + arrow keys (#10776)

abidlabs · gradio-pr-bot · web-flow · commit 85f6132f1f9f · 2025-03-10T14:39:55.000-07:00
* changes

* add changeset

* changes

* add changeset

* remove console

---------

Co-authored-by: gradio-pr-bot &lt;gradio-pr-bot@users.noreply.github.com&gt;
diff --git a/.changeset/yellow-paws-grin.md b/.changeset/yellow-paws-grin.md
@@ -0,0 +1,6 @@
+---
+"@gradio/dataframe": patch
+"gradio": patch
+---
+
+feat:Fix cell selection when using shift + arrow keys
diff --git a/js/dataframe/shared/selection_utils.ts b/js/dataframe/shared/selection_utils.ts
@@ -37,8 +37,14 @@ export function get_range_selection(
 	const max_col = Math.max(start_col, end_col);
 
 	const cells: CellCoordinate[] = [];
+	// Add the start cell as the "anchor" cell so that when
+	// we press shift+arrow keys, the selection will always
+	// include the anchor cell.
+	cells.push(start);
+
 	for (let i = min_row; i <= max_row; i++) {
 		for (let j = min_col; j <= max_col; j++) {
+			if (i === start_row && j === start_col) continue;
 			cells.push([i, j]);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,14 @@ export function get_range_selection(`
`37`	`37`	`const max_col = Math.max(start_col, end_col);`
`38`	`38`
`39`	`39`	`const cells: CellCoordinate[] = [];`
	`40`	`+ // Add the start cell as the "anchor" cell so that when`
	`41`	`+ // we press shift+arrow keys, the selection will always`
	`42`	`+ // include the anchor cell.`
	`43`	`+ cells.push(start);`
	`44`	`+`
`40`	`45`	`for (let i = min_row; i <= max_row; i++) {`
`41`	`46`	`for (let j = min_col; j <= max_col; j++) {`
	`47`	`+ if (i === start_row && j === start_col) continue;`
`42`	`48`	`cells.push([i, j]);`
`43`	`49`	`}`
`44`	`50`	`}`