Skip to content

Commit 4344898

Browse files
committed
chore: review comments incorporated
1 parent f0424ed commit 4344898

File tree

1 file changed

+13
-24
lines changed

1 file changed

+13
-24
lines changed

gotocompany/guardian/v1beta1/guardian.proto

Lines changed: 13 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -811,7 +811,7 @@ message ListGrantsRequest {
811811
string q = 15;
812812
repeated string group_ids = 16;
813813
repeated string group_types = 17;
814-
bool include_approval_details = 18;
814+
bool with_approvals = 18;
815815
}
816816

817817
message ListGrantsResponse {
@@ -1007,29 +1007,6 @@ message PolicyAppealConfig {
10071007
google.protobuf.Value value = 5;
10081008
}
10091009
map<string, MetadataSource> metadata_sources = 7;
1010-
1011-
message Step {
1012-
string name = 1;
1013-
string description = 2;
1014-
bool allow_failed = 3;
1015-
string when = 4;
1016-
string strategy = 5;
1017-
repeated string approvers = 6;
1018-
bool approve_if = 7;
1019-
bool dont_allow_self_approval = 8;
1020-
}
1021-
1022-
message StepData {
1023-
repeated Step steps = 1;
1024-
google.protobuf.Value metadata = 2;
1025-
}
1026-
1027-
message DynamicPolicySteps {
1028-
string type = 1;
1029-
google.protobuf.Value config = 2;
1030-
StepData step_data = 3;
1031-
}
1032-
DynamicPolicySteps dynamic_policy_steps = 8;
10331010
}
10341011

10351012
// Policy is a configurable steps for appeal's approval
@@ -1093,6 +1070,18 @@ message Policy {
10931070
IAM iam = 9;
10941071

10951072
PolicyAppealConfig appeal = 10;
1073+
1074+
message StepData {
1075+
repeated ApprovalStep steps = 1;
1076+
google.protobuf.Value metadata = 2;
1077+
}
1078+
1079+
message CustomSteps {
1080+
string type = 1;
1081+
google.protobuf.Value config = 2;
1082+
StepData step_data = 3;
1083+
}
1084+
CustomSteps custom_steps = 11;
10961085
}
10971086

10981087
message AppealOptions {

0 commit comments

Comments
 (0)