Skip to content

Conversation

@gorhom
Copy link
Owner

@gorhom gorhom commented Feb 1, 2021

close #250

Motivation

with this pr, animatedIndex and animatedPosition won't be interpolated until the layout is calculated.

Installation

yarn add ssh://[email protected]:gorhom/react-native-bottom-sheet#fix/animated-variables-flickering-v3

@gorhom gorhom added the v3 Written in Reanimated v2 label Feb 1, 2021
@gorhom
Copy link
Owner Author

gorhom commented Feb 1, 2021

@ferrannp could you please test this pr :)

@gorhom gorhom linked an issue Feb 1, 2021 that may be closed by this pull request
@ferrannp
Copy link

ferrannp commented Feb 2, 2021

Hey @gorhom, mmm it seems that it is still happening. In the code I cannot share happens all the time. In the playground https://github.com/ferrannp/bottom-sheet-playground happens less but if you keep reloading JS, you can see it still happens. See:

refresh

In this gif, the first reload is ok, the second one has the flash. It is a bit random, sometimes flashes on mount, sometimes not, etc.

@ferrannp
Copy link

ferrannp commented Feb 4, 2021

FYI @gorhom this still happens even with the #246 fix.

@gorhom
Copy link
Owner Author

gorhom commented Feb 4, 2021

could you try again with , make sure you clean metro cache and install this pr again

@ferrannp
Copy link

ferrannp commented Feb 9, 2021

@gorhom still sometimes happening to me.

@gorhom
Copy link
Owner Author

gorhom commented Feb 9, 2021

@ferrannp hmm i can't reproduce it 😩 , i would suggest to merge this pr since it provide more a stable animatedIndex ?

@ferrannp
Copy link

ferrannp commented Feb 9, 2021

Yeah let's try and release @gorhom. Then I will try again with real version and try to reproduce it again.

@gorhom gorhom merged commit 0498e8c into v3 Feb 10, 2021
@gorhom gorhom deleted the fix/animated-variables-flickering-v3 branch February 10, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3 Written in Reanimated v2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v3] BottomSheetBackdrop flashes on mounting

3 participants