fix: prevent default backdrop from blocking ui behind

[gorhom]

close #242

Motivation

replacing TouchableWithoutFeedback with TapGestureHandler solves the issue

[hanno-ferrannegre]

@gorhom I can confirm this works as expected 👍.

Edit: It breaks any interaction when the sheet is open on Android. Everything was working on Android so maybe you just need to apply the changes for iOS?

[gorhom]

i will investigate it on Android later today, thanks for spotting this issue 😅

[gorhom]

hi @hanno-ferrannegre , i did test it on android, and seems fine 🧐

i used your repo https://github.com/ferrannp/bottom-sheet-playground

Screen.Recording.2021-02-01.at.18.46.30.mp4

[ferrannp]

So weird @gorhom, look what it does in my Pixel 4 (real device):

A part from the Open button problem (that is probably elevation thing), I cannot then interact with the sheet (close it by gesture) and tapping the backdrop does nothing either.

On the other hand, installing the 3.2.1 works well on Android 😅 .

By the way you don't seem to have latest version of the repo (with react-navigation bottom tabs).

[gorhom]

@ferrannp i did test it in a simulator and pixel-c device with latest react-navigation and bottoms-tabs and it works fine , could you clear your metro cache and try again ?

[ferrannp]

Mmm @gorhom:

yarn add ssh://[email protected]:gorhom/react-native-bottom-sheet#fix/backdrop-touchable-component
rm -rf android/app/build
yarn start --reset-cache
yarn android

Still getting the same. So strange... You sure you don't have another change locally/not pushed? Or I am doing something wrong 😅 .

[gorhom]

@ferrannp hmm , okay , will test it shortly

[gorhom]

hmm downgrading react-native-safe-area-context to 0.7.3 fix the issue 🧐,

i'll investigate it more

[gorhom]

hey @ferrannp , could you try the latest commit ... last one i promise 😅

[ferrannp]

@gorhom no problem, I can try as many times as necessary 😄 .

Unfortunately, I still get it broken on Android (like in the gif I posted) 😕 .

[gorhom]

ah yea, i notice in your repo that you did not integrate react-native-gesture-handler on android , please complete its setup and try again :)

[ferrannp]

JAAA, oh boy totally forgot about that. Too many projects 😅 . It is definitely working. So let's release it! Thank you!!!