fix: crash on swipe down (#1367)(by @beqramo)

beqramo · gorhom · web-flow · commit 235466fef552 · 2023-06-04T16:36:15.000+02:00
* fix: crash on swipe down

* fix: keyboard dismiss on JS thread

* fix: call the keyboard dismiss method

---------

Co-authored-by: Mo Gorhom &lt;gorhom.dev@gmail.com&gt;
diff --git a/src/hooks/useGestureEventsHandlersDefault.tsx b/src/hooks/useGestureEventsHandlersDefault.tsx
@@ -21,7 +21,7 @@ type GestureEventContextType = {
   isScrollablePositionLocked: boolean;
 };
 
-const dismissKeyboardOnJs = runOnJS(Keyboard.dismiss);
+const dismissKeyboard = Keyboard.dismiss
 
 export const useGestureEventsHandlersDefault: GestureEventsHandlersHookType =
   () => {
@@ -298,7 +298,7 @@ export const useGestureEventsHandlersDefault: GestureEventsHandlersHookType =
                 absoluteY > WINDOW_HEIGHT - animatedKeyboardHeight.value
               )
             ) {
-              dismissKeyboardOnJs();
+              runOnJS(dismissKeyboard)();
             }
           }
 

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ type GestureEventContextType = {`
`21`	`21`	`isScrollablePositionLocked: boolean;`
`22`	`22`	`};`
`23`	`23`
`24`		`-const dismissKeyboardOnJs = runOnJS(Keyboard.dismiss);`
	`24`	`+const dismissKeyboard = Keyboard.dismiss`
`25`	`25`
`26`	`26`	`export const useGestureEventsHandlersDefault: GestureEventsHandlersHookType =`
`27`	`27`	`() => {`
`@@ -298,7 +298,7 @@ export const useGestureEventsHandlersDefault: GestureEventsHandlersHookType =`
`298`	`298`	`absoluteY > WINDOW_HEIGHT - animatedKeyboardHeight.value`
`299`	`299`	`)`
`300`	`300`	`) {`
`301`		`- dismissKeyboardOnJs();`
	`301`	`+ runOnJS(dismissKeyboard)();`
`302`	`302`	`}`
`303`	`303`	`}`
`304`	`304`