feat: add effect that smoothly fades in/out audio #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix "hanning" to "hann" & use Abs for the deciding whether to fade in.
Add comments
Fix typo
Author
|
OK, I believe this one is good to go. I've tested it quite a bit and using it in this form in my own code now. Let me know if you'd like more docs etc. |
Contributor
|
I wrote some questions in #31 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an effect that smoothly (and quickly) fades in and out audio to avoid clicks and pops. It uses a very small, pre-calculated Hanning window.
This resolves my issues in #31.