Skip to content

Commit 3df3d09

Browse files
mcreinhardcopybara-github
authored andcommitted
fix: fix "hasWheelchairAccessibleEntrance" boolean field due to API changes
PiperOrigin-RevId: 609792119
1 parent 5fed3e7 commit 3df3d09

3 files changed

Lines changed: 21 additions & 16 deletions

File tree

src/place_building_blocks/place_field_boolean/place_field_boolean.ts

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ function getFieldValue(place: Place, field: PlaceBooleanField): boolean|null|
9999
case 'hasTakeout':
100100
return place.hasTakeout;
101101
case 'hasWheelchairAccessibleEntrance':
102-
return place.hasWheelchairAccessibleEntrance;
102+
return place.accessibilityOptions?.hasWheelchairAccessibleEntrance;
103103
case 'isReservable':
104104
return place.isReservable;
105105
case 'servesBeer':
@@ -191,14 +191,17 @@ export class PlaceFieldBoolean extends PlaceDataConsumer {
191191
getRequiredFields(): Array<keyof Place> {
192192
if (!this.field) return [];
193193
const placeField = toPlaceBooleanField(this.field);
194-
if (placeField === 'isOpen()') {
195-
return [
196-
'businessStatus',
197-
'openingHours',
198-
'utcOffsetMinutes',
199-
];
200-
} else {
201-
return [placeField];
194+
switch (placeField) {
195+
case 'isOpen()':
196+
return [
197+
'businessStatus',
198+
'openingHours',
199+
'utcOffsetMinutes',
200+
];
201+
case 'hasWheelchairAccessibleEntrance':
202+
return ['accessibilityOptions'];
203+
default:
204+
return [placeField];
202205
}
203206
}
204207

src/place_building_blocks/place_field_boolean/place_field_boolean_test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ describe('place field boolean test', () => {
5656
hasDelivery: true,
5757
hasDineIn: true,
5858
hasTakeout: true,
59-
hasWheelchairAccessibleEntrance: true,
59+
accessibilityOptions: {hasWheelchairAccessibleEntrance: true},
6060
isReservable: true,
6161
servesBeer: true,
6262
servesBreakfast: true,
@@ -91,7 +91,7 @@ describe('place field boolean test', () => {
9191
hasDelivery: false,
9292
hasDineIn: false,
9393
hasTakeout: false,
94-
hasWheelchairAccessibleEntrance: false,
94+
accessibilityOptions: {hasWheelchairAccessibleEntrance: false},
9595
isReservable: false,
9696
servesBeer: false,
9797
servesBreakfast: false,
@@ -126,7 +126,7 @@ describe('place field boolean test', () => {
126126
hasDelivery: null,
127127
hasDineIn: null,
128128
hasTakeout: null,
129-
hasWheelchairAccessibleEntrance: null,
129+
accessibilityOptions: {hasWheelchairAccessibleEntrance: null},
130130
isReservable: null,
131131
servesBeer: null,
132132
servesBreakfast: null,
@@ -362,4 +362,4 @@ describe('place field boolean test', () => {
362362

363363
expect(lifecycleSpy.hostUpdatedCount).toBe(2);
364364
});
365-
});
365+
});

src/utils/googlemaps_types.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,15 @@ export declare interface SearchByTextRequest {
3737
}
3838

3939
/** Updated Place class with new attribution schema. */
40-
export declare type Place =
41-
Omit<google.maps.places.Place, 'photos'|'reviews'|'fetchFields'>& {
40+
export declare interface Place extends Omit<
41+
google.maps.places.Place,
42+
'photos'|'reviews'|'fetchFields'|'hasWheelchairAccessibleEntrance'> {
4243
photos?: Photo[];
4344
reviews?: Review[];
45+
accessibilityOptions?: {hasWheelchairAccessibleEntrance: boolean|null}|null;
4446
fetchFields: (options: google.maps.places.FetchFieldsRequest) =>
4547
Promise<{place: Place}>;
46-
};
48+
}
4749

4850
/** Places library. */
4951
export declare interface PlacesLibrary extends

0 commit comments

Comments
 (0)