Skip to content

Commit 6acd0cd

Browse files
authored
Update AbstractServiceStubSettingsClassComposer.java
1 parent 868965e commit 6acd0cd

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/main/java/com/google/api/generator/gapic/composer/common/AbstractServiceStubSettingsClassComposer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,8 @@ private static Expr createPagedListDescriptorAssignExpr(
582582
.build();
583583

584584
// While protobufs should not be null, this null-check is needed to protect against NPEs
585-
// in paged iteration, as some clients actually return null instead of an empty list.
585+
// in paged iteration on clients that use legacy HTTP/JSON types, as these clients can
586+
// actually return null instead of an empty list.
586587
// Context:
587588
// Original issue: https://github.com/googleapis/google-cloud-java/issues/3736
588589
// Relevant discussion where this check was first added:

0 commit comments

Comments
 (0)