Skip to content

Commit b2f851a

Browse files
authored
feat!: require node 18 (#5225)
1 parent 2f1d9bd commit b2f851a

13 files changed

Lines changed: 1207 additions & 588 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
- uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3
3535
- uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3
3636
with:
37-
node-version: ${{ (matrix.package == 'gcf-utils' || matrix.package == 'issue-utils' || matrix.package == 'canary-bot' || matrix.package == 'datastore-lock' ) && 18 || 14 }}
37+
node-version: ${{ (endsWith(matrix.package, '-utils') || matrix.package == 'canary-bot' || matrix.package == 'datastore-lock' || matrix.package == 'object-selector' ) && 18 || 14 }}
3838
- run: echo ./packages/${{ matrix.package }}
3939
- run: cd ./packages/${{ matrix.package }}
4040
- run: npm ci

packages/bot-config-utils/package-lock.json

Lines changed: 44 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/bot-config-utils/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"compile": "tsc -p .",
77
"pretest": "npm run compile",
88
"prepare": "npm run compile",
9-
"test": "cross-env NODE_ENV=test LOG_LEVEL=fatal c8 mocha ./build/test",
9+
"test": "cross-env NODE_ENV=test LOG_LEVEL=fatal c8 mocha --node-option no-experimental-fetch ./build/test",
1010
"test:snap": "SNAPSHOT_UPDATE=1 npm test",
1111
"system-test": "npm run pretest && cross-env LOG_LEVEL=fatal mocha ./build/test/integration",
1212
"fix": "gts fix",
@@ -19,7 +19,7 @@
1919
"dependencies": {
2020
"ajv": "^8.11.0",
2121
"ajv-formats": "^2.1.1",
22-
"gcf-utils": "^14.0.1",
22+
"gcf-utils": "^15.0.0",
2323
"js-yaml": "^4.1.0",
2424
"jsonwebtoken": "^9.0.0"
2525
},
@@ -40,7 +40,7 @@
4040
"typescript": "^4.9.4"
4141
},
4242
"engines": {
43-
"node": ">= 14"
43+
"node": ">= 18"
4444
},
4545
"keywords": [
4646
"Bot config",

packages/cron-utils/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/cron-utils/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"compile": "tsc -p .",
77
"pretest": "npm run compile",
88
"prepare": "npm run compile",
9-
"test": "cross-env NODE_ENV=test LOG_LEVEL=fatal c8 mocha ./build/test",
9+
"test": "cross-env NODE_ENV=test LOG_LEVEL=fatal c8 mocha --node-option no-experimental-fetch ./build/test",
1010
"system-test": "npm run pretest && cross-env LOG_LEVEL=fatal mocha ./build/test/integration",
1111
"fix": "gts fix",
1212
"lint": "gts check"
@@ -41,7 +41,7 @@
4141
"typescript": "^4.9.4"
4242
},
4343
"engines": {
44-
"node": ">= 14"
44+
"node": ">= 18"
4545
},
4646
"keywords": [],
4747
"author": "Jeff Ching <chingor@google.com>",

packages/git-file-utils/package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/git-file-utils/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"compile": "tsc -p .",
77
"pretest": "npm run compile",
88
"prepare": "npm run compile",
9-
"test": "cross-env NODE_ENV=test LOG_LEVEL=fatal c8 mocha ./build/test",
9+
"test": "cross-env NODE_ENV=test LOG_LEVEL=fatal c8 mocha --node-option no-experimental-fetch ./build/test",
1010
"test:snap": "SNAPSHOT_UPDATE=1 npm test",
1111
"system-test": "npm run pretest && cross-env LOG_LEVEL=fatal mocha ./build/test/integration",
1212
"fix": "gts fix",
@@ -39,7 +39,7 @@
3939
"typescript": "^4.9.4"
4040
},
4141
"engines": {
42-
"node": ">= 14"
42+
"node": ">= 18"
4343
},
4444
"keywords": [
4545
"Git data API"
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
{
2-
"extends": "./node_modules/gts"
2+
"extends": "./node_modules/gts",
3+
"root": true
34
}

0 commit comments

Comments
 (0)