deps(bot-config-utils)!: use gcf-utils 14 (#4143)

* deps(bot-config-utils)!: use gcf-utils 14
* build: drop node 12 support
* deps(datastore-lock)!: use gcf-utils 14
* deps(issue-utils)!: use gcf-utils 14
* deps(object-selector)!: use gcf-utils 14
* build: install lru-cache as a dev dependency

Author: Takashi Matsuo

packages/bot-config-utils/package-lock.json

@@ -19,25 +19,25 @@
   "dependencies": {
     "ajv": "^8.11.0",
     "js-yaml": "^4.1.0",
-    "gcf-utils": "^13.8.1"
+    "gcf-utils": "^14.0.0"
   },
   "devDependencies": {
-    "@octokit/types": "^6.35.0",
+    "@octokit/types": "^6.41.0",
     "@types/mocha": "^9.1.1",
-    "@types/node": "^18.0.0",
-    "@types/sinon": "^10.0.11",
-    "c8": "^7.11.3",
+    "@types/node": "^18.7.2",
+    "@types/sinon": "^10.0.13",
+    "c8": "^7.12.0",
     "cross-env": "^7.0.3",
     "dotenv": "^16.0.1",
     "gts": "^3.1.0",
     "mocha": "^10.0.0",
-    "nock": "^13.2.7",
+    "nock": "^13.2.9",
     "sinon": "^14.0.0",
     "snap-shot-it": "^7.9.6",
     "typescript": "~4.7.4"
   },
   "engines": {
-    "node": ">= 12.18.2"
+    "node": ">= 14"
   },
   "keywords": [
     "Bot config",

packages/bot-config-utils/package.json

@@ -22,6 +22,9 @@ import {describe, it, beforeEach} from 'mocha';
 import {Probot, ProbotOctokit} from 'probot';
 // eslint-disable-next-line node/no-extraneous-import
 import {Octokit} from '@octokit/rest';
+import {getAuthenticatedOctokit} from 'gcf-utils';
+import * as gcfUtilsModule from 'gcf-utils';
+import * as sinon from 'sinon';
 
 import {
   getConfig,
@@ -64,7 +67,7 @@ const app = (app: Probot) => {
         CONFIG_FILENAME
       );
       await configChecker.validateConfigChanges(
-        context.octokit,
+        await getAuthenticatedOctokit(context.payload.installation!.id),
         context.payload.pull_request.head.user.login,
         context.payload.repository.name,
         context.payload.pull_request.head.sha,
@@ -90,7 +93,7 @@ const app2 = (app: Probot) => {
         CONFIG_FILENAME_YML
       );
       await configChecker.validateConfigChanges(
-        context.octokit,
+        await getAuthenticatedOctokit(context.payload.installation!.id),
         context.payload.pull_request.head.user.login,
         context.payload.repository.name,
         context.payload.pull_request.head.sha,
@@ -116,7 +119,7 @@ const app3 = (app: Probot) => {
         [schema]
       );
       await configChecker.validateConfigChanges(
-        context.octokit,
+        await getAuthenticatedOctokit(context.payload.installation!.id),
         context.payload.pull_request.head.user.login,
         context.payload.repository.name,
         context.payload.pull_request.head.sha,
@@ -173,8 +176,11 @@ function fetchFilesInPR(configFile: string, fileName: string) {
     .reply(200, createConfigResponse(configFile));
 }
 
+let getAuthenticatedOctokitStub: sinon.SinonStub;
+
 describe('config test app with config.yml', () => {
   let probot: Probot;
+  const sandbox = sinon.createSandbox();
   beforeEach(() => {
     probot = new Probot({
       githubToken: 'abc123',
@@ -184,12 +190,16 @@ describe('config test app with config.yml', () => {
       }),
     });
     probot.load(app2);
-  });
-  beforeEach(() => {
     nock.disableNetConnect();
+    getAuthenticatedOctokitStub = sandbox.stub(
+      gcfUtilsModule,
+      'getAuthenticatedOctokit'
+    );
+    getAuthenticatedOctokitStub.resolves(new Octokit());
   });
   afterEach(() => {
     nock.cleanAll();
+    sandbox.restore();
   });
   describe('responds to PR', () => {
     it('creates a failing status check for a wrong file name', async () => {
@@ -211,6 +221,7 @@ describe('config test app with config.yml', () => {
 
 describe('config test app', () => {
   let probot: Probot;
+  const sandbox = sinon.createSandbox();
   beforeEach(() => {
     probot = new Probot({
       githubToken: 'abc123',
@@ -223,9 +234,15 @@ describe('config test app', () => {
     // It always start from null.
     configFromConfigChecker = null;
     nock.disableNetConnect();
+    getAuthenticatedOctokitStub = sandbox.stub(
+      gcfUtilsModule,
+      'getAuthenticatedOctokit'
+    );
+    getAuthenticatedOctokitStub.resolves(new Octokit());
   });
   afterEach(() => {
     nock.cleanAll();
+    sandbox.restore();
   });
   describe('responds to PR', () => {
     it('does not die upon 404 github api responses', async () => {
@@ -311,6 +328,7 @@ describe('config test app', () => {
 
 describe('config test app with multiple schema files', () => {
   let probot: Probot;
+  const sandbox = sinon.createSandbox();
   beforeEach(() => {
     probot = new Probot({
       githubToken: 'abc123',
@@ -323,9 +341,15 @@ describe('config test app with multiple schema files', () => {
     // It always start from null.
     listConfigFromConfigChecker = null;
     nock.disableNetConnect();
+    getAuthenticatedOctokitStub = sandbox.stub(
+      gcfUtilsModule,
+      'getAuthenticatedOctokit'
+    );
+    getAuthenticatedOctokitStub.resolves(new Octokit());
   });
   afterEach(() => {
     nock.cleanAll();
+    sandbox.restore();
   });
   describe('responds to PR', () => {
     it('does not creates a failing status check for a correct config', async () => {

packages/bot-config-utils/test/bot-config-utils.ts

@@ -14,7 +14,7 @@
 const config = {
   "enable-source-maps": true,
   "throw-deprecation": true,
-  "timeout": 20000
+  "timeout": 120000
 }
 if (process.env.MOCHA_THROW_DEPRECATION === 'false') {
   delete config['throw-deprecation'];