Skip to content

feat: add support for use_auth_w_custom_endpoint #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cojenco merged 6 commits into from
Nov 29, 2022
Merged

feat: add support for use_auth_w_custom_endpoint #901

cojenco merged 6 commits into from
Nov 29, 2022

Conversation

@cojenco
Copy link
Contributor

@cojenco cojenco commented Nov 10, 2022 •
edited
Loading

This adds a boolean flag use_auth_w_custom_endpoint - whether authentication is required with custom endpoints

  • only used when a custom endpoint in set in conjunction
  • defaults to True and uses authentication
  • if set to False, bypasses authentication

For backwards compatibility

  • by default, auth is bypassed when STORAGE_EMULATOR_HOST is set

Fixes #895 and internal b/258502260

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Nov 10, 2022
frankyn
frankyn reviewed Nov 10, 2022
View reviewed changes
@cojenco cojenco added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 11, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 11, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2022
@cojenco cojenco marked this pull request as ready for review November 15, 2022 00:21
@cojenco cojenco requested review from a team as code owners November 15, 2022 00:21
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2022
andrewsg
andrewsg approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had one question, otherwise LGTM. Thanks!

@cojenco cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 16, 2022
@cojenco
Copy link
Contributor Author

cojenco commented Nov 17, 2022

Update: pending discussion with the GCS EngProd team to streamline usage and validate testing against non-prod environments

@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2022
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2022
@cojenco
Copy link
Contributor Author

cojenco commented Nov 28, 2022

Synced offline with @rsaksham - prepod testing should not be affected by this change.

PR is ready to merge and release once freeze ends

@cojenco cojenco removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 29, 2022
@cojenco cojenco merged commit 4862a9c into googleapis:main Nov 29, 2022
@release-please release-please bot mentioned this pull request Nov 29, 2022
Merged
rsaksham added a commit to rsaksham/python-storage that referenced this pull request Nov 29, 2022
@rsaksham
Revert "feat: add support for use_auth_w_custom_endpoint (googleapis#901
c46a70d 
)"

This reverts commit 4862a9c.
@cojenco cojenco mentioned this pull request Nov 29, 2022
Closed
cojenco added a commit that referenced this pull request Nov 29, 2022
@cojenco
Revert "feat: add support for use_auth_w_custom_endpoint (#901)"
ba76344 
This reverts commit 4862a9c.
@cojenco cojenco mentioned this pull request Nov 29, 2022
Merged
cojenco added a commit that referenced this pull request Nov 29, 2022
@cojenco
Revert "feat: add support for use_auth_w_custom_endpoint (#901)" (#940)
1ca0233 
This reverts commit 4862a9c.
@cojenco cojenco deleted the custom-endpoint branch November 16, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsg andrewsg andrewsg approved these changes

+1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable authentication when a non-default api_endpoint is set (just like the googleapis/nodejs-storage)

4 participants

@cojenco @andrewsg @frankyn @yoshi-kokoro