fix: dont pass credentials to StorageClient (#1608)

chandra-siri · web-flow · commit 195d644c4d4f · 2025-11-12T14:15:27.000+05:30
if transport is provided with credentials. gRPC client will throw [error](https://github.com/googleapis/python-storage/blob/323cddd5d439e04e12614106eab1928fd4008c0b/google/cloud/_storage_v2/services/storage/client.py#L691-L695) if credentials are passed to client's instance in addition to passing it to transport.
diff --git a/google/cloud/storage/_experimental/asyncio/async_grpc_client.py b/google/cloud/storage/_experimental/asyncio/async_grpc_client.py
@@ -69,7 +69,6 @@ def _create_async_grpc_client(
         transport = transport_cls(credentials=credentials, channel=channel)
 
         return storage_v2.StorageAsyncClient(
-            credentials=credentials,
             transport=transport,
             client_info=client_info,
             client_options=client_options,
diff --git a/tests/unit/asyncio/test_async_grpc_client.py b/tests/unit/asyncio/test_async_grpc_client.py
@@ -46,7 +46,6 @@ def test_constructor_default_options(self, mock_async_storage_client):
         )
         mock_transport = mock_transport_cls.return_value
         mock_async_storage_client.assert_called_once_with(
-            credentials=mock_creds,
             transport=mock_transport,
             client_options=None,
             client_info=None,

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@ def test_constructor_default_options(self, mock_async_storage_client):`
`46`	`46`	`)`
`47`	`47`	`mock_transport = mock_transport_cls.return_value`
`48`	`48`	`mock_async_storage_client.assert_called_once_with(`
`49`		`- credentials=mock_creds,`
`50`	`49`	`transport=mock_transport,`
`51`	`50`	`client_options=None,`
`52`	`51`	`client_info=None,`