Skip to content
This repository was archived by the owner on Mar 2, 2026. It is now read-only.

fix: bulk_writer default assignment#565

Merged
Mariatta merged 2 commits intogoogleapis:mainfrom
didi-rf:patch-1
May 26, 2022
Merged

fix: bulk_writer default assignment#565
Mariatta merged 2 commits intogoogleapis:mainfrom
didi-rf:patch-1

Conversation

@didi-rf
Copy link
Copy Markdown
Contributor

@didi-rf didi-rf commented Apr 12, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #564 🦕

@didi-rf didi-rf requested review from a team April 12, 2022 09:06
@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/python-firestore API. labels Apr 12, 2022
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Apr 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@didi-rf didi-rf changed the title Fix bulk_writer default assignment fix: bulk_writer default assignment Apr 12, 2022
Copy link
Copy Markdown
Contributor

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM

@Mariatta Mariatta added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 24, 2022
@gcf-merge-on-green
Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 25, 2022
@tmatsuo tmatsuo added the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2022
@Mariatta Mariatta merged commit 843c278 into googleapis:main May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bulk_writer default assignment not working in Client.recursive_delete

4 participants