fix: Watch thread deadlock on exit #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: firestore
product-auto-label
bot
added
size: s
danieljbruce
approved these changes
Feb 21, 2025
gkevinzheng
pushed a commit
that referenced
this pull request
Apr 30, 2025
* fix: fix thread cleanup when destroying Watch instance * added test for on_snapshot while closing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #985 (comment)
When tearing down the background watcher thread, it would cause lock re-entry in the Watch._closing lock, which meant the thread would deadlock, and not be cleaned up properly.
This PR prevents on_snapshot messages from propagating when the Watch instance is in the process of closing down