Skip to content

Commit b5ee820

Browse files
fix: release scripts from issuing overlapping phases
`mvn deploy` will run `mvn install` so specifying `mvn install deploy` is redundant at best. At worst, it will cause plugins like maven-shade-plugin to be executed twice re-shading itself Source-Author: Igor Bernstein <[email protected]> Source-Date: Wed Apr 14 13:16:03 2021 -0400 Source-Repo: googleapis/synthtool Source-Sha: 8285c2b4cdbc3771d031ad91e1c4ec9e55fff45d Source-Link: googleapis/synthtool@8285c2b
1 parent f0c0a86 commit b5ee820

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

.kokoro/release/snapshot.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ grep SNAPSHOT versions.txt
2525
setup_environment_secrets
2626
create_settings_xml_file "settings.xml"
2727

28-
mvn clean install deploy -B \
28+
mvn clean deploy -B \
2929
--settings ${MAVEN_SETTINGS_FILE} \
3030
-DperformRelease=true \
3131
-Dgpg.executable=gpg \

.kokoro/release/stage.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ create_settings_xml_file "settings.xml"
2929

3030
# attempt to stage 3 times with exponential backoff (starting with 10 seconds)
3131
retry_with_backoff 3 10 \
32-
mvn clean install deploy -B \
32+
mvn clean deploy -B \
3333
--settings ${MAVEN_SETTINGS_FILE} \
3434
-DskipTests=true \
3535
-DperformRelease=true \

synth.metadata

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@
44
"git": {
55
"name": ".",
66
"remote": "https://github.com/googleapis/java-storage-nio.git",
7-
"sha": "d6c79c020112b7321cc9781522bddf98d131f990"
7+
"sha": "f0c0a86067050da4d98b9a03ffaf1c71c6a9f846"
88
}
99
},
1010
{
1111
"git": {
1212
"name": "synthtool",
1313
"remote": "https://github.com/googleapis/synthtool.git",
14-
"sha": "5b0e1592dd7d70b485e157ea4b3eb1704ecbd015"
14+
"sha": "8285c2b4cdbc3771d031ad91e1c4ec9e55fff45d"
1515
}
1616
}
1717
],
@@ -26,6 +26,7 @@
2626
".github/readme/synth.py",
2727
".github/release-please.yml",
2828
".github/snippet-bot.yml",
29+
".github/sync-repo-settings.yaml",
2930
".github/trusted-contribution.yml",
3031
".github/workflows/approve-readme.yaml",
3132
".github/workflows/auto-release.yaml",

0 commit comments

Comments
 (0)