Raise ValueError if credentials are not from google-auth (#2828)

Author: Jon Wayne Parrott

packages/google-cloud-dns/tox.ini

@@ -7,6 +7,7 @@ localdeps =
     pip install --quiet --upgrade {toxinidir}/../core
 deps =
     {toxinidir}/../core
+    mock
     pytest
 covercmd =
     py.test --quiet \

packages/google-cloud-dns/unit_tests/test_client.py

@@ -14,6 +14,13 @@
 
 import unittest
 
+import mock
+
+
+def _make_credentials():
+    import google.auth.credentials
+    return mock.Mock(spec=google.auth.credentials.Credentials)
+
 
 class TestClient(unittest.TestCase):
 
@@ -30,7 +37,7 @@ def _make_one(self, *args, **kw):
 
     def test_ctor(self):
         from google.cloud.dns.connection import Connection
-        creds = object()
+        creds = _make_credentials()
         http = object()
         client = self._make_one(project=self.PROJECT, credentials=creds,
                                 http=http)
@@ -58,7 +65,7 @@ def test_quotas_defaults(self):
         }
         CONVERTED = {key: int(value)
                      for key, value in DATA['quota'].items()}
-        creds = object()
+        creds = _make_credentials()
         client = self._make_one(self.PROJECT, creds)
         conn = client._connection = _Connection(DATA)
 
@@ -93,7 +100,7 @@ def test_quotas_w_kind_key(self):
                      for key, value in DATA['quota'].items()}
         WITH_KIND = {'quota': DATA['quota'].copy()}
         WITH_KIND['quota']['kind'] = 'dns#quota'
-        creds = object()
+        creds = _make_credentials()
         client = self._make_one(self.PROJECT, creds)
         conn = client._connection = _Connection(WITH_KIND)
 
@@ -130,7 +137,7 @@ def test_list_zones_defaults(self):
                  'dnsName': DNS_2},
             ]
         }
-        creds = object()
+        creds = _make_credentials()
         client = self._make_one(self.PROJECT, creds)
         conn = client._connection = _Connection(DATA)
 
@@ -175,7 +182,7 @@ def test_list_zones_explicit(self):
                  'dnsName': DNS_2},
             ]
         }
-        creds = object()
+        creds = _make_credentials()
         client = self._make_one(self.PROJECT, creds)
         conn = client._connection = _Connection(DATA)
 
@@ -203,7 +210,7 @@ def test_zone_explicit(self):
         from google.cloud.dns.zone import ManagedZone
         DESCRIPTION = 'DESCRIPTION'
         DNS_NAME = 'test.example.com'
-        creds = object()
+        creds = _make_credentials()
         client = self._make_one(self.PROJECT, creds)
         zone = client.zone(self.ZONE_NAME, DNS_NAME, DESCRIPTION)
         self.assertIsInstance(zone, ManagedZone)
@@ -215,7 +222,7 @@ def test_zone_explicit(self):
     def test_zone_w_dns_name_wo_description(self):
         from google.cloud.dns.zone import ManagedZone
         DNS_NAME = 'test.example.com'
-        creds = object()
+        creds = _make_credentials()
         client = self._make_one(self.PROJECT, creds)
         zone = client.zone(self.ZONE_NAME, DNS_NAME)
         self.assertIsInstance(zone, ManagedZone)
@@ -226,7 +233,7 @@ def test_zone_w_dns_name_wo_description(self):
 
     def test_zone_wo_dns_name(self):
         from google.cloud.dns.zone import ManagedZone
-        creds = object()
+        creds = _make_credentials()
         client = self._make_one(self.PROJECT, creds)
         zone = client.zone(self.ZONE_NAME)
         self.assertIsInstance(zone, ManagedZone)