Skip to content

Commit d3ef455

Browse files
authored
Removing googleapis-common-protos from deps in non-core packages. (#4098)
* Removing `googleapis-common-protos` from deps in non-`core` packages. Also - removing `grpcio` from non-`core` packages. - manually specifying the `grpcio` dep in core (rather than getting it from `googleapis-common-protos[grpc]`) * Making `grpc` an extra for `core`. * Adding `googleapis-common-protos` back to `videointelligence`.
1 parent 9fddaf0 commit d3ef455

File tree

9 files changed

+10
-16
lines changed

9 files changed

+10
-16
lines changed

core/setup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151

5252

5353
REQUIREMENTS = [
54-
'googleapis-common-protos[grpc] >= 1.5.3, < 2.0dev',
54+
'googleapis-common-protos >= 1.5.3, < 2.0dev',
5555
'protobuf >= 3.0.0',
5656
'google-auth >= 0.4.0, < 2.0.0dev',
5757
'requests >= 2.18.0, < 3.0.0dev',
@@ -61,6 +61,7 @@
6161

6262
EXTRAS_REQUIREMENTS = {
6363
':python_version<"3.2"': ['futures >= 3.0.0'],
64+
'grpc': ['grpcio >= 1.2.0, < 1.6dev'],
6465
}
6566

6667
setup(

language/setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,8 @@
5151

5252

5353
REQUIREMENTS = [
54-
'google-cloud-core >= 0.27.0, < 0.28dev',
54+
'google-cloud-core[grpc] >= 0.27.1, < 0.28dev',
5555
'google-gax >= 0.15.14, < 0.16dev',
56-
'googleapis-common-protos[grpc] >= 1.5.3, < 2.0dev',
5756
]
5857
EXTRAS_REQUIRE = {
5958
':python_version<"3.4"': ['enum34'],

logging/setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@
5151

5252

5353
REQUIREMENTS = [
54-
'google-cloud-core >= 0.27.0, < 0.28dev',
55-
'grpcio >= 1.2.0, < 1.6dev',
54+
'google-cloud-core[grpc] >= 0.27.1, < 0.28dev',
5655
'gapic-google-cloud-logging-v2 >= 0.91.0, < 0.92dev',
5756
]
5857

pubsub/setup.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,11 +51,9 @@
5151

5252

5353
REQUIREMENTS = [
54-
'google-cloud-core >= 0.27.0, < 0.28dev',
54+
'google-cloud-core[grpc] >= 0.27.1, < 0.28dev',
5555
'google-gax >= 0.15.13, < 0.16dev',
56-
'googleapis-common-protos[grpc] >= 1.5.3, < 2.0dev',
5756
'grpc-google-iam-v1 >= 0.11.1, < 0.12dev',
58-
'grpcio >= 1.2.0, < 1.6dev',
5957
'psutil >= 5.2.2, < 6.0dev',
6058
]
6159

spanner/setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,8 @@
5252

5353
REQUIREMENTS = [
5454
'google-auth >= 1.1.0',
55-
'google-cloud-core >= 0.27.0, < 0.28dev',
55+
'google-cloud-core[grpc] >= 0.27.1, < 0.28dev',
5656
'google-gax>=0.15.15, <0.16dev',
57-
'googleapis-common-protos[grpc]>=1.5.3, <2.0dev',
5857
'grpc-google-iam-v1>=0.11.4, <0.12dev',
5958
'requests>=2.18.4, <3.0dev',
6059
]

speech/setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,8 @@
5252
}
5353

5454
REQUIREMENTS = [
55-
'google-cloud-core >= 0.27.0, < 0.28dev',
55+
'google-cloud-core[grpc] >= 0.27.1, < 0.28dev',
5656
'google-gax >= 0.15.14, < 0.16dev',
57-
'googleapis-common-protos[grpc] >= 1.5.3, < 2.0dev',
5857
]
5958

6059
setup(

trace/setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@
99

1010
install_requires = [
1111
'google-gax>=0.15.7, <0.16dev',
12-
'googleapis-common-protos[grpc]>=1.5.3, <2.0dev',
13-
'google-cloud-core >= 0.27.0, < 0.28dev',
12+
'google-cloud-core[grpc] >= 0.27.1, < 0.28dev',
1413
]
1514

1615
setup(

videointelligence/setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
install_requires=(
4141
'googleapis-common-protos >= 1.5.3, < 2.0dev',
4242
'google-gax >= 0.15.14, < 0.16dev',
43+
'grpcio >= 1.2.0, < 1.6dev',
4344
'six >= 1.10.0',
4445
),
4546
url='https://github.com/GoogleCloudPlatform/google-cloud-python',

vision/setup.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,8 @@
2525
readme = readme_file.read()
2626

2727
REQUIREMENTS = [
28-
'google-cloud-core >= 0.27.0, < 0.28dev',
28+
'google-cloud-core[grpc] >= 0.27.1, < 0.28dev',
2929
'google-gax >= 0.15.14, < 0.16dev',
30-
'googleapis-common-protos[grpc] >= 1.5.3, < 2.0dev',
3130
]
3231
EXTRAS_REQUIRE = {
3332
':python_version<"3.4"': ['enum34'],

0 commit comments

Comments
 (0)