Revert "BigQuery: docs for Row.keys, items, values, and get functions. (#4410)" (#4412)

This reverts commit f3e745e.

Author: tswast

bigquery/google/cloud/bigquery/table.py

@@ -16,7 +16,6 @@
 
 from __future__ import absolute_import
 
-import copy
 import datetime
 import operator
 
@@ -784,73 +783,43 @@ def __init__(self, values, field_to_index):
         self._xxx_field_to_index = field_to_index
 
     def values(self):
-        """Return the values included in this row.
-
-        Returns:
-            Sequence[object]: A sequence of length ``len(row)``.
-        """
-        for value in self._xxx_values:
-            yield copy.deepcopy(value)
+        return self._xxx_values
 
     def keys(self):
-        """Return the keys for using a row as a dict.
-
-        Returns:
-            Sequence[str]: The keys corresponding to the columns of a row
-
-        Examples:
-
-            >>> list(Row(('a', 'b'), {'x': 0, 'y': 1}).keys())
-            ['x', 'y']
         """
-        return six.iterkeys(self._xxx_field_to_index)
+        Return keys as of a dict:
+        >>> Row(('a', 'b'), {'x': 0, 'y': 1}).keys()
+        ['x', 'y']
+        """
+        keys = self._xxx_field_to_index.keys()
+        return keys
 
     def items(self):
-        """Return items as ``(key, value)`` pairs.
-
-        Returns:
-            Sequence[Tuple[str, object]]:
-                The ``(key, value)`` pairs representing this row.
-
-        Examples:
-
-            >>> list(Row(('a', 'b'), {'x': 0, 'y': 1}).items())
-            [('x', 'a'), ('y', 'b')]
         """
-        for key, index in six.iteritems(self._xxx_field_to_index):
-            yield (key, copy.deepcopy(self._xxx_values[index]))
+        Return items as of a dict:
+        >>> Row(('a', 'b'), {'x': 0, 'y': 1}).items()
+        [('x', 'a'), ('y', 'b')]
+        """
+        items = [
+            (k, self._xxx_values[i])
+            for k, i
+            in self._xxx_field_to_index.items()
+        ]
+        return items
 
     def get(self, key, default=None):
-        """Return a value for key, with a default value if it does not exist.
-
-        Args:
-            key (str): The key of the column to access
-            default (object):
-                The default value to use if the key does not exist. (Defaults
-                to :data:`None`.)
-
-        Returns:
-            object:
-                The value associated with the provided key, or a default value.
-
-        Examples:
-            When the key exists, the value associated with it is returned.
-
-            >>> Row(('a', 'b'), {'x': 0, 'y': 1}).get('x')
-            'a'
-
-            The default value is ``None`` when the key does not exist.
-
-            >>> Row(('a', 'b'), {'x': 0, 'y': 1}).get('z')
-            None
-
-            The default value can be overrided with the ``default`` parameter.
-
-            >>> Row(('a', 'b'), {'x': 0, 'y': 1}).get('z', '')
-            ''
-
-            >>> Row(('a', 'b'), {'x': 0, 'y': 1}).get('z', default = '')
-            ''
+        """
+        Return value under specified key
+        Defaults to None or specified default
+        if key does not exist:
+        >>> Row(('a', 'b'), {'x': 0, 'y': 1}).get('x')
+        'a'
+        >>> Row(('a', 'b'), {'x': 0, 'y': 1}).get('z')
+        None
+        >>> Row(('a', 'b'), {'x': 0, 'y': 1}).get('z', '')
+        ''
+        >>> Row(('a', 'b'), {'x': 0, 'y': 1}).get('z', default = '')
+        ''
         """
         index = self._xxx_field_to_index.get(key)
         if index is None:

bigquery/tests/unit/test_table.py

@@ -764,7 +764,7 @@ def test_row(self):
         self.assertEqual(row[1], 2)
         self.assertEqual(row['c'], 3)
         self.assertEqual(len(row), 3)
-        self.assertEqual(tuple(row.values()), VALUES)
+        self.assertEqual(row.values(), VALUES)
         self.assertEqual(set(row.keys()), set({'a': 1, 'b': 2, 'c': 3}.keys()))
         self.assertEqual(set(row.items()),
                          set({'a': 1, 'b': 2, 'c': 3}.items()))