Skip to content

Commit 81c403c

Browse files
slowy07slowy07
authored
chore: code clean up (#351)
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-dialogflow/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) Fixes #350 🦕
1 parent 79569e5 commit 81c403c

2 files changed

Lines changed: 173 additions & 173 deletions

File tree

‎packages/google-cloud-dialogflow/scripts/fixup_dialogflow_v2_keywords.py‎

Lines changed: 83 additions & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -39,88 +39,88 @@ def partition(
3939
class dialogflowCallTransformer(cst.CSTTransformer):
4040
CTRL_PARAMS: Tuple[str] = ('retry', 'timeout', 'metadata')
4141
METHOD_TO_PARAMS: Dict[str, Tuple[str]] = {
42-
'analyze_content': ('participant', 'text_input', 'event_input', 'reply_audio_config', 'query_params', 'request_id', ),
43-
'batch_create_entities': ('parent', 'entities', 'language_code', ),
44-
'batch_delete_entities': ('parent', 'entity_values', 'language_code', ),
45-
'batch_delete_entity_types': ('parent', 'entity_type_names', ),
46-
'batch_delete_intents': ('parent', 'intents', ),
47-
'batch_update_entities': ('parent', 'entities', 'language_code', 'update_mask', ),
48-
'batch_update_entity_types': ('parent', 'entity_type_batch_uri', 'entity_type_batch_inline', 'language_code', 'update_mask', ),
49-
'batch_update_intents': ('parent', 'intent_batch_uri', 'intent_batch_inline', 'language_code', 'update_mask', 'intent_view', ),
50-
'complete_conversation': ('name', ),
51-
'create_context': ('parent', 'context', ),
52-
'create_conversation': ('parent', 'conversation', 'conversation_id', ),
53-
'create_conversation_profile': ('parent', 'conversation_profile', ),
54-
'create_document': ('parent', 'document', ),
55-
'create_entity_type': ('parent', 'entity_type', 'language_code', ),
56-
'create_environment': ('parent', 'environment', 'environment_id', ),
57-
'create_intent': ('parent', 'intent', 'language_code', 'intent_view', ),
58-
'create_knowledge_base': ('parent', 'knowledge_base', ),
59-
'create_participant': ('parent', 'participant', ),
60-
'create_session_entity_type': ('parent', 'session_entity_type', ),
61-
'create_version': ('parent', 'version', ),
62-
'delete_agent': ('parent', ),
63-
'delete_all_contexts': ('parent', ),
64-
'delete_context': ('name', ),
65-
'delete_conversation_profile': ('name', ),
66-
'delete_document': ('name', ),
67-
'delete_entity_type': ('name', ),
68-
'delete_environment': ('name', ),
69-
'delete_intent': ('name', ),
70-
'delete_knowledge_base': ('name', 'force', ),
71-
'delete_session_entity_type': ('name', ),
72-
'delete_version': ('name', ),
73-
'detect_intent': ('session', 'query_input', 'query_params', 'output_audio_config', 'output_audio_config_mask', 'input_audio', ),
74-
'export_agent': ('parent', 'agent_uri', ),
75-
'get_agent': ('parent', ),
76-
'get_context': ('name', ),
77-
'get_conversation': ('name', ),
78-
'get_conversation_profile': ('name', ),
79-
'get_document': ('name', ),
80-
'get_entity_type': ('name', 'language_code', ),
81-
'get_environment': ('name', ),
82-
'get_environment_history': ('parent', 'page_size', 'page_token', ),
83-
'get_fulfillment': ('name', ),
84-
'get_intent': ('name', 'language_code', 'intent_view', ),
85-
'get_knowledge_base': ('name', ),
86-
'get_participant': ('name', ),
87-
'get_session_entity_type': ('name', ),
88-
'get_validation_result': ('parent', 'language_code', ),
89-
'get_version': ('name', ),
90-
'import_agent': ('parent', 'agent_uri', 'agent_content', ),
91-
'list_answer_records': ('parent', 'filter', 'page_size', 'page_token', ),
92-
'list_contexts': ('parent', 'page_size', 'page_token', ),
93-
'list_conversation_profiles': ('parent', 'page_size', 'page_token', ),
94-
'list_conversations': ('parent', 'page_size', 'page_token', 'filter', ),
95-
'list_documents': ('parent', 'page_size', 'page_token', ),
96-
'list_entity_types': ('parent', 'language_code', 'page_size', 'page_token', ),
97-
'list_environments': ('parent', 'page_size', 'page_token', ),
98-
'list_intents': ('parent', 'language_code', 'intent_view', 'page_size', 'page_token', ),
99-
'list_knowledge_bases': ('parent', 'page_size', 'page_token', ),
100-
'list_messages': ('parent', 'filter', 'page_size', 'page_token', ),
101-
'list_participants': ('parent', 'page_size', 'page_token', ),
102-
'list_session_entity_types': ('parent', 'page_size', 'page_token', ),
103-
'list_versions': ('parent', 'page_size', 'page_token', ),
104-
'reload_document': ('name', 'content_uri', ),
105-
'restore_agent': ('parent', 'agent_uri', 'agent_content', ),
106-
'search_agents': ('parent', 'page_size', 'page_token', ),
107-
'set_agent': ('agent', 'update_mask', ),
108-
'streaming_detect_intent': ('session', 'query_input', 'query_params', 'single_utterance', 'output_audio_config', 'output_audio_config_mask', 'input_audio', ),
109-
'suggest_articles': ('parent', 'latest_message', 'context_size', ),
110-
'suggest_faq_answers': ('parent', 'latest_message', 'context_size', ),
111-
'train_agent': ('parent', ),
112-
'update_answer_record': ('answer_record', 'update_mask', ),
113-
'update_context': ('context', 'update_mask', ),
114-
'update_conversation_profile': ('conversation_profile', 'update_mask', ),
115-
'update_document': ('document', 'update_mask', ),
116-
'update_entity_type': ('entity_type', 'language_code', 'update_mask', ),
117-
'update_environment': ('environment', 'update_mask', 'allow_load_to_draft_and_discard_changes', ),
118-
'update_fulfillment': ('fulfillment', 'update_mask', ),
119-
'update_intent': ('intent', 'language_code', 'update_mask', 'intent_view', ),
120-
'update_knowledge_base': ('knowledge_base', 'update_mask', ),
121-
'update_participant': ('participant', 'update_mask', ),
122-
'update_session_entity_type': ('session_entity_type', 'update_mask', ),
123-
'update_version': ('version', 'update_mask', ),
42+
'analyze_content': ('participant', 'text_input', 'event_input', 'reply_audio_config', 'query_params', 'request_id', ),
43+
'batch_create_entities': ('parent', 'entities', 'language_code', ),
44+
'batch_delete_entities': ('parent', 'entity_values', 'language_code', ),
45+
'batch_delete_entity_types': ('parent', 'entity_type_names', ),
46+
'batch_delete_intents': ('parent', 'intents', ),
47+
'batch_update_entities': ('parent', 'entities', 'language_code', 'update_mask', ),
48+
'batch_update_entity_types': ('parent', 'entity_type_batch_uri', 'entity_type_batch_inline', 'language_code', 'update_mask', ),
49+
'batch_update_intents': ('parent', 'intent_batch_uri', 'intent_batch_inline', 'language_code', 'update_mask', 'intent_view', ),
50+
'complete_conversation': ('name', ),
51+
'create_context': ('parent', 'context', ),
52+
'create_conversation': ('parent', 'conversation', 'conversation_id', ),
53+
'create_conversation_profile': ('parent', 'conversation_profile', ),
54+
'create_document': ('parent', 'document', ),
55+
'create_entity_type': ('parent', 'entity_type', 'language_code', ),
56+
'create_environment': ('parent', 'environment', 'environment_id', ),
57+
'create_intent': ('parent', 'intent', 'language_code', 'intent_view', ),
58+
'create_knowledge_base': ('parent', 'knowledge_base', ),
59+
'create_participant': ('parent', 'participant', ),
60+
'create_session_entity_type': ('parent', 'session_entity_type', ),
61+
'create_version': ('parent', 'version', ),
62+
'delete_agent': ('parent', ),
63+
'delete_all_contexts': ('parent', ),
64+
'delete_context': ('name', ),
65+
'delete_conversation_profile': ('name', ),
66+
'delete_document': ('name', ),
67+
'delete_entity_type': ('name', ),
68+
'delete_environment': ('name', ),
69+
'delete_intent': ('name', ),
70+
'delete_knowledge_base': ('name', 'force', ),
71+
'delete_session_entity_type': ('name', ),
72+
'delete_version': ('name', ),
73+
'detect_intent': ('session', 'query_input', 'query_params', 'output_audio_config', 'output_audio_config_mask', 'input_audio', ),
74+
'export_agent': ('parent', 'agent_uri', ),
75+
'get_agent': ('parent', ),
76+
'get_context': ('name', ),
77+
'get_conversation': ('name', ),
78+
'get_conversation_profile': ('name', ),
79+
'get_document': ('name', ),
80+
'get_entity_type': ('name', 'language_code', ),
81+
'get_environment': ('name', ),
82+
'get_environment_history': ('parent', 'page_size', 'page_token', ),
83+
'get_fulfillment': ('name', ),
84+
'get_intent': ('name', 'language_code', 'intent_view', ),
85+
'get_knowledge_base': ('name', ),
86+
'get_participant': ('name', ),
87+
'get_session_entity_type': ('name', ),
88+
'get_validation_result': ('parent', 'language_code', ),
89+
'get_version': ('name', ),
90+
'import_agent': ('parent', 'agent_uri', 'agent_content', ),
91+
'list_answer_records': ('parent', 'filter', 'page_size', 'page_token', ),
92+
'list_contexts': ('parent', 'page_size', 'page_token', ),
93+
'list_conversation_profiles': ('parent', 'page_size', 'page_token', ),
94+
'list_conversations': ('parent', 'page_size', 'page_token', 'filter', ),
95+
'list_documents': ('parent', 'page_size', 'page_token', ),
96+
'list_entity_types': ('parent', 'language_code', 'page_size', 'page_token', ),
97+
'list_environments': ('parent', 'page_size', 'page_token', ),
98+
'list_intents': ('parent', 'language_code', 'intent_view', 'page_size', 'page_token', ),
99+
'list_knowledge_bases': ('parent', 'page_size', 'page_token', ),
100+
'list_messages': ('parent', 'filter', 'page_size', 'page_token', ),
101+
'list_participants': ('parent', 'page_size', 'page_token', ),
102+
'list_session_entity_types': ('parent', 'page_size', 'page_token', ),
103+
'list_versions': ('parent', 'page_size', 'page_token', ),
104+
'reload_document': ('name', 'content_uri', ),
105+
'restore_agent': ('parent', 'agent_uri', 'agent_content', ),
106+
'search_agents': ('parent', 'page_size', 'page_token', ),
107+
'set_agent': ('agent', 'update_mask', ),
108+
'streaming_detect_intent': ('session', 'query_input', 'query_params', 'single_utterance', 'output_audio_config', 'output_audio_config_mask', 'input_audio', ),
109+
'suggest_articles': ('parent', 'latest_message', 'context_size', ),
110+
'suggest_faq_answers': ('parent', 'latest_message', 'context_size', ),
111+
'train_agent': ('parent', ),
112+
'update_answer_record': ('answer_record', 'update_mask', ),
113+
'update_context': ('context', 'update_mask', ),
114+
'update_conversation_profile': ('conversation_profile', 'update_mask', ),
115+
'update_document': ('document', 'update_mask', ),
116+
'update_entity_type': ('entity_type', 'language_code', 'update_mask', ),
117+
'update_environment': ('environment', 'update_mask', 'allow_load_to_draft_and_discard_changes', ),
118+
'update_fulfillment': ('fulfillment', 'update_mask', ),
119+
'update_intent': ('intent', 'language_code', 'update_mask', 'intent_view', ),
120+
'update_knowledge_base': ('knowledge_base', 'update_mask', ),
121+
'update_participant': ('participant', 'update_mask', ),
122+
'update_session_entity_type': ('session_entity_type', 'update_mask', ),
123+
'update_version': ('version', 'update_mask', ),
124124
}
125125

126126
def leave_Call(self, original: cst.Call, updated: cst.Call) -> cst.CSTNode:
@@ -139,7 +139,7 @@ def leave_Call(self, original: cst.Call, updated: cst.Call) -> cst.CSTNode:
139139
return updated
140140

141141
kwargs, ctrl_kwargs = partition(
142-
lambda a: not a.keyword.value in self.CTRL_PARAMS,
142+
lambda a: a.keyword.value not in self.CTRL_PARAMS,
143143
kwargs
144144
)
145145

0 commit comments

Comments
 (0)