Skip to content

Commit 703f431

Browse files
authored
docs: clarify TODO for reenabling erroring on warnings (#405)
1 parent d00032f commit 703f431

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

packages/proto-plus/noxfile.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,11 @@ def unit(session, proto="python"):
5050
if proto == "cpp": # 4.20 does not have cpp.
5151
session.install("protobuf==3.19.0")
5252

53-
# The warnings as errors flag `-W=error` was removed in
53+
# TODO(https://github.com/googleapis/proto-plus-python/issues/403): re-enable `-W=error`
54+
# The warnings-as-errors flag `-W=error` was removed in
5455
# https://github.com/googleapis/proto-plus-python/pull/400.
5556
# It should be re-added once issue
56-
# https://github.com/googleapis/proto-plus-python/issues/403 is fixed.
57-
# See also https://github.com/protocolbuffers/protobuf/issues/12186.
57+
# https://github.com/protocolbuffers/protobuf/issues/12186 is fixed.
5858
session.run(
5959
"py.test",
6060
"--quiet",

0 commit comments

Comments
 (0)