Skip to content

Commit 14d688c

Browse files
committed
Updating system test and docs for list_sinks() change.
1 parent 9a3e3b2 commit 14d688c

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

docs/logging-usage.rst

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -342,8 +342,7 @@ List all sinks for a project:
342342

343343
>>> from google.cloud import logging
344344
>>> client = logging.Client()
345-
>>> sinks, token = client.list_sinks()
346-
>>> for sink in sinks:
345+
>>> for sink in client.list_sinks(): # API call(s)
347346
... print('%s: %s' % (sink.name, sink.destination))
348347
robots-storage: storage.googleapis.com/my-bucket-name
349348
robots-bq: bigquery.googleapis.com/projects/my-project/datasets/my-dataset

system_tests/logging_.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -398,12 +398,12 @@ def test_list_sinks(self):
398398
uri = self._init_storage_bucket()
399399
sink = Config.CLIENT.sink(SINK_NAME, DEFAULT_FILTER, uri)
400400
self.assertFalse(sink.exists())
401-
before_sinks, _ = Config.CLIENT.list_sinks()
401+
before_sinks = list(Config.CLIENT.list_sinks())
402402
before_names = set(sink.name for sink in before_sinks)
403403
sink.create()
404404
self.to_delete.append(sink)
405405
self.assertTrue(sink.exists())
406-
after_sinks, _ = Config.CLIENT.list_sinks()
406+
after_sinks = list(Config.CLIENT.list_sinks())
407407
after_names = set(sink.name for sink in after_sinks)
408408
self.assertEqual(after_names - before_names,
409409
set([SINK_NAME]))

0 commit comments

Comments
 (0)