Skip to content

Commit 96ab971

Browse files
don't parse an undefined message or body
1 parent f23d3d5 commit 96ab971

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

lib/common/util.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,8 @@ function handleResp(err, resp, body, callback) {
142142
var parsedResp = extend(
143143
true,
144144
{ err: err || null },
145-
util.parseHttpRespMessage(resp),
146-
util.parseHttpRespBody(body)
145+
resp && util.parseHttpRespMessage(resp),
146+
body && util.parseHttpRespBody(body)
147147
);
148148

149149
callback(parsedResp.err, parsedResp.body, parsedResp.resp);

test/common/util.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,22 @@ describe('common/util', function() {
230230
done();
231231
});
232232
});
233+
234+
it('should not parse undefined response', function(done) {
235+
utilOverrides.parseHttpRespMessage = function() {
236+
done(); // Will throw.
237+
};
238+
239+
util.handleResp(null, null, null, done);
240+
});
241+
242+
it('should not parse undefined body', function(done) {
243+
utilOverrides.parseHttpRespBody = function() {
244+
done(); // Will throw.
245+
};
246+
247+
util.handleResp(null, null, null, done);
248+
});
233249
});
234250

235251
describe('parseHttpRespMessage', function() {

0 commit comments

Comments
 (0)