Skip to content

Commit 87ffdce

Browse files
docs(contributing): remove AngularJS confusion
Eliminate potential confusion caused by referring to the AngularJS repo. We also prefer the use of a `common` scope over `app` for library-wide changes. Resolves #224
1 parent 812bace commit 87ffdce

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

CONTRIBUTING.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The test coverage report will be available in `coverage/`.
5959

6060
## Commit Guidelines
6161

62-
We follow the AngularJS [commit conventions][ngcontributing]. Please model your commit message after the following structure:
62+
Please model your commit message after the following structure:
6363

6464
```
6565
<type>(<scope>): <subject>
@@ -71,13 +71,13 @@ We follow the AngularJS [commit conventions][ngcontributing]. Please model your
7171

7272
- All lines must be limited to 72 characters
7373
- For `<scope>`, you may use:
74-
- `app` for an application-wide change
74+
- `common` for a change impacting the entire library
7575
- `datastore`
7676
- `pubsub`
7777
- `storage`
7878
- etc.
7979

80-
Be sure to read the AngularJS [contributing document][ngcontributing]. For a thorough explanation, see the [AngularJS Git Commit Message Conventions doc][commitdoc].
80+
For a thorough explanation, see this [Git Commit Message Conventions doc][commitdoc].
8181

8282
## Contributor License Agreements
8383

@@ -92,5 +92,4 @@ You can sign these electronically (just scroll to the bottom). After that, we'll
9292
[gcloudcli]: https://developers.google.com/cloud/sdk/gcloud/
9393
[indvcla]: https://developers.google.com/open-source/cla/individual
9494
[corpcla]: https://developers.google.com/open-source/cla/corporate
95-
[ngcontributing]: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
9695
[commitdoc]: https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#

0 commit comments

Comments
 (0)