Skip to content

Commit 61dab93

Browse files
yoshi-automationGautamSharda
authored andcommitted
feat(secrets): begin migration to secret manager from keystore (#740)
1 parent cf11301 commit 61dab93

9 files changed

Lines changed: 61 additions & 11 deletions

File tree

handwritten/bigtable/.kokoro/populate-secrets.sh

Lines changed: 32 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

handwritten/bigtable/.kokoro/publish.sh

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

handwritten/bigtable/.kokoro/release/publish.cfg

Lines changed: 3 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

handwritten/bigtable/.kokoro/trampoline.sh

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

handwritten/bigtable/protos/protos.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
var $Reader = $protobuf.Reader, $Writer = $protobuf.Writer, $util = $protobuf.util;
2929

3030
// Exported root namespace
31-
var $root = $protobuf.roots._google_cloud_bigtable_2_3_2_protos || ($protobuf.roots._google_cloud_bigtable_2_3_2_protos = {});
31+
var $root = $protobuf.roots._google_cloud_bigtable_protos || ($protobuf.roots._google_cloud_bigtable_protos = {});
3232

3333
$root.google = (function() {
3434

handwritten/bigtable/src/v2/bigtable_client.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,13 @@ export class BigtableClient {
9090
}
9191
opts.servicePath = opts.servicePath || servicePath;
9292
opts.port = opts.port || port;
93+
94+
// users can override the config from client side, like retry codes name.
95+
// The detailed structure of the clientConfig can be found here: https://github.com/googleapis/gax-nodejs/blob/master/src/gax.ts#L546
96+
// The way to override client config for Showcase API:
97+
//
98+
// const customConfig = {"interfaces": {"google.showcase.v1beta1.Echo": {"methods": {"Echo": {"retry_codes_name": "idempotent", "retry_params_name": "default"}}}}}
99+
// const showcaseClient = new showcaseClient({ projectId, customConfig });
93100
opts.clientConfig = opts.clientConfig || {};
94101

95102
const isBrowser = typeof window !== 'undefined';

handwritten/bigtable/src/v2/bigtable_instance_admin_client.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,13 @@ export class BigtableInstanceAdminClient {
104104
}
105105
opts.servicePath = opts.servicePath || servicePath;
106106
opts.port = opts.port || port;
107+
108+
// users can override the config from client side, like retry codes name.
109+
// The detailed structure of the clientConfig can be found here: https://github.com/googleapis/gax-nodejs/blob/master/src/gax.ts#L546
110+
// The way to override client config for Showcase API:
111+
//
112+
// const customConfig = {"interfaces": {"google.showcase.v1beta1.Echo": {"methods": {"Echo": {"retry_codes_name": "idempotent", "retry_params_name": "default"}}}}}
113+
// const showcaseClient = new showcaseClient({ projectId, customConfig });
107114
opts.clientConfig = opts.clientConfig || {};
108115

109116
const isBrowser = typeof window !== 'undefined';

handwritten/bigtable/src/v2/bigtable_table_admin_client.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,13 @@ export class BigtableTableAdminClient {
105105
}
106106
opts.servicePath = opts.servicePath || servicePath;
107107
opts.port = opts.port || port;
108+
109+
// users can override the config from client side, like retry codes name.
110+
// The detailed structure of the clientConfig can be found here: https://github.com/googleapis/gax-nodejs/blob/master/src/gax.ts#L546
111+
// The way to override client config for Showcase API:
112+
//
113+
// const customConfig = {"interfaces": {"google.showcase.v1beta1.Echo": {"methods": {"Echo": {"retry_codes_name": "idempotent", "retry_params_name": "default"}}}}}
114+
// const showcaseClient = new showcaseClient({ projectId, customConfig });
108115
opts.clientConfig = opts.clientConfig || {};
109116

110117
const isBrowser = typeof window !== 'undefined';

handwritten/bigtable/synth.metadata

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"git": {
55
"name": ".",
66
"remote": "https://github.com/googleapis/nodejs-bigtable.git",
7-
"sha": "f0de974c718d47a1fe537c5ae95b801eb8b8c1c1"
7+
"sha": "5d8458dcd498016ff41136ee444bf49cf475ed3f"
88
}
99
},
1010
{
@@ -19,7 +19,7 @@
1919
"git": {
2020
"name": "synthtool",
2121
"remote": "https://github.com/googleapis/synthtool.git",
22-
"sha": "be74d3e532faa47eb59f1a0eaebde0860d1d8ab4"
22+
"sha": "1c92077459db3dc50741e878f98b08c6261181e0"
2323
}
2424
}
2525
],

0 commit comments

Comments
 (0)