Skip to content

Commit 54aa223

Browse files
fix: synth.py clean up for multiple version (#343)
1 parent ae266b6 commit 54aa223

3 files changed

Lines changed: 24 additions & 16 deletions

File tree

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2019 Google LLC
1+
// Copyright 2020 Google LLC
22
//
33
// Licensed under the Apache License, Version 2.0 (the "License");
44
// you may not use this file except in compliance with the License.
@@ -12,17 +12,16 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414
//
15-
// ** This file is automatically generated by gapic-generator-typescript. **
16-
// ** https://github.com/googleapis/gapic-generator-typescript **
15+
// ** This file is automatically generated by synthtool. **
16+
// ** https://github.com/googleapis/synthtool **
1717
// ** All changes to this file may be overwritten. **
1818

19-
import * as v1beta from './v1beta';
2019
import * as v1 from './v1';
20+
import * as v1beta from './v1beta';
2121

2222
const OsLoginServiceClient = v1.OsLoginServiceClient;
23-
export {v1beta, v1, OsLoginServiceClient};
24-
// For compatibility with JavaScript libraries we need to provide this default export:
25-
// tslint:disable-next-line no-default-export
26-
export default {v1beta, v1, OsLoginServiceClient};
23+
24+
export {v1, v1beta, OsLoginServiceClient};
25+
export default {v1, v1beta, OsLoginServiceClient};
2726
import * as protos from '../protos/protos';
2827
export {protos};

packages/google-cloud-oslogin/synth.metadata

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,22 @@
44
"git": {
55
"name": ".",
66
"remote": "git@github.com:googleapis/nodejs-os-login.git",
7-
"sha": "59a874f2ad586f54b994e0ee8ed3c7920eb15126"
7+
"sha": "579f1e48ef2a3f0fd1460b07592d5dc499cf8043"
8+
}
9+
},
10+
{
11+
"git": {
12+
"name": "googleapis",
13+
"remote": "https://github.com/googleapis/googleapis.git",
14+
"sha": "6dfd72d028a0d0a43764e060f7b15e004385c3a1",
15+
"internalRef": "310168181"
816
}
917
},
1018
{
1119
"git": {
1220
"name": "synthtool",
1321
"remote": "https://github.com/googleapis/synthtool.git",
14-
"sha": "ab883569eb0257bbf16a6d825fd018b3adde3912"
22+
"sha": "756bc4dfc24e8bc4c5dd4116daa41a0440ebf5a0"
1523
}
1624
}
1725
],
@@ -20,7 +28,7 @@
2028
"client": {
2129
"source": "googleapis",
2230
"apiName": "os-login",
23-
"apiVersion": "v1beta",
31+
"apiVersion": "v1",
2432
"language": "typescript",
2533
"generator": "gapic-generator-typescript"
2634
}
@@ -29,7 +37,7 @@
2937
"client": {
3038
"source": "googleapis",
3139
"apiName": "os-login",
32-
"apiVersion": "v1",
40+
"apiVersion": "v1beta",
3341
"language": "typescript",
3442
"generator": "gapic-generator-typescript"
3543
}

packages/google-cloud-oslogin/synth.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,27 +25,28 @@
2525

2626

2727
gapic = gcp.GAPICMicrogenerator()
28-
versions = ['v1beta', 'v1']
28+
versions = ['v1', 'v1beta']
2929
for version in versions:
3030
library = gapic.typescript_library(
3131
'os-login',
3232
generator_args={
3333
"grpc-service-config": f"google/cloud/oslogin/{version}/oslogin_grpc_service_config.json",
3434
"package-name": f"@google-cloud/os-login"
35-
},
35+
},
3636
proto_path=f'/google/cloud/oslogin/{version}',
3737
extra_proto_files=['google/cloud/oslogin/common/common.proto'],
3838
version=version)
3939

4040
# skip index, protos, package.json, and README.md
4141
s.copy(
4242
library,
43-
excludes=['package.json', 'README.md', 'src/index.ts'],
43+
excludes=['package.json', 'README.md'],
4444
)
4545

4646
# Copy common templates
4747
common_templates = gcp.CommonTemplates()
48-
templates = common_templates.node_library(source_location='build/src')
48+
templates = common_templates.node_library(
49+
source_location='build/src', versions=versions, default_version='v1')
4950
s.copy(templates)
5051

5152
node.postprocess_gapic_library()

0 commit comments

Comments
 (0)