feat!: drop node8 support, support for async iterators (#682)

Author: alexander-fenster

handwritten/bigtable/.eslintrc.json

@@ -0,0 +1,3 @@
+{
+  "extends": "./node_modules/gts"
+}

handwritten/bigtable/.eslintrc.yml

@@ -0,0 +1,17 @@
+// Copyright 2020 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+module.exports = {
+  ...require('gts/.prettierrc.json')
+}

handwritten/bigtable/.prettierrc

@@ -51,7 +51,7 @@
     "dot-prop": "^5.0.0",
     "escape-string-regexp": "^2.0.0",
     "extend": "^3.0.2",
-    "google-gax": "^1.14.2",
+    "google-gax": "^2.0.1",
     "is": "^3.0.1",
     "is-utf8": "^0.2.1",
     "lodash.snakecase": "^4.1.1",
@@ -63,6 +63,7 @@
     "through2": "^3.0.0"
   },
   "devDependencies": {
+    "@grpc/grpc-js": "^0.7.5",
     "@types/escape-string-regexp": "^1.0.0",
     "@types/extend": "^3.0.1",
     "@types/is": "0.0.21",
@@ -82,7 +83,8 @@
     "eslint-config-prettier": "^6.10.0",
     "eslint-plugin-node": "^11.0.0",
     "eslint-plugin-prettier": "^3.1.2",
-    "gts": "^1.1.2",
+    "google-auth-library": "^6.0.0",
+    "gts": "2.0.0-alpha.9",
     "jsdoc": "^3.6.3",
     "jsdoc-fresh": "^1.0.2",
     "jsdoc-region-tag": "^1.0.4",
@@ -97,9 +99,9 @@
     "power-assert": "^1.6.1",
     "prettier": "^1.19.1",
     "proxyquire": "^2.0.0",
-    "sinon": "^9.0.0",
+    "sinon": "^9.0.1",
     "ts-loader": "^6.2.1",
-    "typescript": "^3.7.0",
+    "typescript": "^3.8.3",
     "uuid": "^7.0.0",
     "webpack": "^4.42.0",
     "webpack-cli": "^3.3.11"

handwritten/bigtable/.prettierrc.js

@@ -15,6 +15,7 @@
 import arrify = require('arrify');
 import * as escapeStringRegexp from 'escape-string-regexp';
 import * as is from 'is';
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 const isUtf8 = require('is-utf8');
 import {Mutation} from './mutation';
 
@@ -47,7 +48,7 @@ export interface Time {
   end: Date | number;
 }
 
-// tslint:disable-next-line no-any
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export type RawFilter = any;
 
 export interface Condition {
@@ -268,7 +269,7 @@ export class Filter {
       [index: string]: Function;
     }
     const filter = new Filter();
-    // tslint:disable-next-line no-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     arrify(filters).forEach((filterObj: any) => {
       const key = Object.keys(filterObj)[0];
       if (typeof ((filter as {}) as Fn)[key] !== 'function') {
@@ -448,7 +449,7 @@ export class Filter {
     }
 
     if (col.start || col.end) {
-      // tslint:disable-next-line no-any
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       const range: any = Filter.createRange(col.start!, col.end!, 'Qualifier');
 
       range.familyName = col.family;

handwritten/bigtable/package.json

@@ -12,33 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-/**
- * @namespace google
- */
-/**
- * @namespace google.bigtable
- */
-/**
- * @namespace google.bigtable.v2
- */
-/**
- * @namespace google.bigtable.admin.v2
- */
-/**
- * @namespace google.iam.v1
- */
-/**
- * @namespace google.rpc
- */
-/**
- * @namespace google.protobuf
- */
-/**
- * @namespace google.type
- */
-/**
- * @namespace google.longrunning
- */
 import {replaceProjectIdToken} from '@google-cloud/projectify';
 import {promisifyAll} from '@google-cloud/promisify';
 import arrify = require('arrify');
@@ -64,9 +37,12 @@ import {google} from '../protos/protos';
 import {ServiceError} from '@grpc/grpc-js';
 import * as v2 from './v2';
 
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 const retryRequest = require('retry-request');
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 const streamEvents = require('stream-events');
 
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 const PKG = require('../../package.json');
 
 const {grpc} = new gax.GrpcClient();
@@ -439,11 +415,8 @@ export class Bigtable {
   appProfileId?: string;
   projectName: string;
   shouldReplaceProjectIdToken: boolean;
-  // tslint:disable-next-line variable-name
   static AppProfile: AppProfile;
-  // tslint:disable-next-line variable-name
   static Instance: Instance;
-  // tslint:disable-next-line variable-name
   static Cluster: Cluster;
 
   constructor(options: BigtableOptions = {}) {
@@ -771,9 +744,9 @@ export class Bigtable {
     return new Instance(this, name);
   }
 
-  // tslint:disable-next-line no-any
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   request<T = any>(config?: any): AbortableDuplex;
-  // tslint:disable-next-line no-any
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   request<T = any>(config?: any, callback?: RequestCallback<T>): void;
   /**
    * Funnel all API requests through this method, to be sure we have a project ID.
@@ -784,7 +757,7 @@ export class Bigtable {
    * @param {object} config.reqOpts Request options.
    * @param {function} [callback] Callback function.
    */
-  // tslint:disable-next-line no-any
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   request<T = any>(
     config: RequestOptions,
     callback?: (err: ServiceError | null, resp?: T) => void
@@ -813,7 +786,7 @@ export class Bigtable {
         if (this.shouldReplaceProjectIdToken && projectId !== '{{projectId}}') {
           reqOpts = replaceProjectIdToken(reqOpts, projectId!);
         }
-        // tslint:disable-next-line:no-any
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
         const requestFn = (gaxClient as any)[config.method!].bind(
           gaxClient,
           reqOpts,
@@ -945,14 +918,13 @@ promisifyAll(Bigtable, {
  */
 
 // Allow creating a `Bigtable` instance without using the `new` keyword.
-// tslint:disable-next-line no-any
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 (Bigtable as any) = new Proxy(Bigtable, {
   apply(target, thisArg, argumentsList) {
-    // tslint:disable-next-line no-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     return new (target as any)(...argumentsList);
   },
 });
-
 /**
  * The default export of the `@google-cloud/bigtable` package is the
  * {@link Bigtable} class.
@@ -986,4 +958,6 @@ promisifyAll(Bigtable, {
 module.exports = Bigtable;
 module.exports.v2 = v2;
 module.exports.Bigtable = Bigtable;
+
+export {v2};
 export {protos};

handwritten/bigtable/src/filter.ts

@@ -89,7 +89,7 @@ export interface InstanceOptions {
    * No more than 64 labels can be associated with a given resource.
    * Keys and values must both be under 128 bytes.
    */
-  // tslint:disable-next-line no-any
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   labels?: {[index: string]: any};
 
   type?: 'production' | 'development';
@@ -478,15 +478,15 @@ Please use the format 'my-instance' or '${bigtable.projectName}/instances/my-ins
     }
 
     if (options.families) {
-      // tslint:disable-next-line no-any
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       const columnFamilies = (options.families as any[]).reduce(
         (families, family) => {
           if (typeof family === 'string') {
             family = {
               name: family,
             };
           }
-          // tslint:disable-next-line no-any
+          // eslint-disable-next-line @typescript-eslint/no-explicit-any
           const columnFamily: any = (families[family.name] = {});
           if (family.rule) {
             columnFamily.gcRule = Family.formatRule_(family.rule);

handwritten/bigtable/src/index.ts

@@ -23,7 +23,7 @@ export type IMutateRowRequest = btTypes.bigtable.v2.IMutateRowRequest;
 export type ISetCell = btTypes.bigtable.v2.Mutation.ISetCell;
 
 export type Bytes = string | Buffer;
-// tslint:disable-next-line:no-any
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export type Data = any;
 export interface JsonObj {
   [k: string]: string | JsonObj;
@@ -111,7 +111,7 @@ export class Mutation {
   ): Buffer | Value | string {
     const buf = bytes instanceof Buffer ? bytes : Buffer.from(bytes, 'base64');
     if (options && options.isPossibleNumber && buf.length === 8) {
-      // tslint:disable-next-line no-any
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       const num = Long.fromBytes(buf as any).toNumber();
 
       if (Number.isSafeInteger(num)) {
@@ -209,7 +209,7 @@ export class Mutation {
     const mutations: SetCellObj[] = [];
 
     Object.keys(data).forEach(familyName => {
-      // tslint:disable-next-line no-any
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       const family = (data as any)[familyName];
 
       Object.keys(family).forEach(cellName => {

handwritten/bigtable/src/instance.ts

@@ -14,14 +14,10 @@
 
 import {promisifyAll} from '@google-cloud/promisify';
 import arrify = require('arrify');
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 const dotProp = require('dot-prop');
 import {Filter, RawFilter} from './filter';
-import {
-  Mutation,
-  ConvertFromBytesUserOptions,
-  Bytes,
-  IMutation,
-} from './mutation';
+import {Mutation, ConvertFromBytesUserOptions, Bytes} from './mutation';
 import {Bigtable} from '.';
 import {
   Table,
@@ -159,7 +155,7 @@ export class Row {
   bigtable: Bigtable;
   table: Table;
   id: string;
-  // tslint:disable-next-line no-any
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   data: any;
   key?: string;
   metadata?: {};
@@ -258,7 +254,7 @@ export class Row {
       }
 
       return row;
-      // tslint:disable-next-line no-any
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
     }, {} as any);
 
     return rows;
@@ -422,7 +418,7 @@ export class Row {
 
     rules = arrify(rules).map(rule => {
       const column = Mutation.parseColumnName(rule.column);
-      // tslint:disable-next-line no-any
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       const ruleData: any = {
         familyName: column.family,
         columnQualifier: Mutation.convertToBytes(column.qualifier!),
@@ -656,18 +652,18 @@ export class Row {
   }
 
   get(options?: GetRowOptions): Promise<GetRowResponse<Row>>;
-  // tslint:disable-next-line no-any
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   get<T = any>(
     columns: string[],
     options?: GetRowOptions
   ): Promise<GetRowResponse<T>>;
-  // tslint:disable-next-line no-any
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   get<T = any>(
     columns: string[],
     options: GetRowOptions,
     callback: GetRowCallback<T>
   ): void;
-  // tslint:disable-next-line no-any
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   get<T = any>(columns: string[], callback: GetRowCallback<T>): void;
   get(callback: GetRowCallback<Row>): void;
   get(options: GetRowOptions, callback: GetRowCallback<Row>): void;
@@ -688,7 +684,7 @@ export class Row {
    * @example <caption>include:samples/document-snippets/row.js</caption>
    * region_tag:bigtable_get_row
    */
-  // tslint:disable-next-line no-any
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   get<T = any | Row>(
     columnsOrOptionsOrCallback?: string[] | GetRowOptions | GetRowCallback<T>,
     optionsOrCallback?: GetRowOptions | GetRowCallback<T>,
@@ -717,7 +713,7 @@ export class Row {
     // if there is column filter
     if (columns.length) {
       const filters = columns.map(Mutation.parseColumnName).map(column => {
-        // tslint:disable-next-line no-any
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
         const colmFilters: any = [{family: column.family}];
         if (column.qualifier) {
           colmFilters.push({column: column.qualifier});