diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java b/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java
index ac63ac5acb60..76d003d3857d 100644
--- a/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java
+++ b/google-cloud-clients/google-cloud-bigtable-admin/src/main/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClient.java
@@ -447,38 +447,37 @@ private ApiFuture
getTableAsync(String tableId, com.google.bigtable.admin
}
/**
- * Lists all TableNames in the instance.
+ * Lists all table ids in the instance.
*
* Sample code:
*
*
{@code
- * List tableNames = client.listTables();
- * for(TableName name : tableNames) {
+ * List tableIds = client.listTables();
+ * for(String tableId: tableIds) {
* System.out.println(name.getTable());
* }
* }
*/
- // TODO(igorbernstein2): consider changing this method to use relative table ids.
@SuppressWarnings("WeakerAccess")
- public List listTables() {
+ public List listTables() {
return ApiExceptions.callAndTranslateApiException(listTablesAsync());
}
/**
- * Asynchronously lists all TableNames in the instance.
+ * Asynchronously lists all table ids in the instance.
*
* Sample code:
*
*
{@code
- * ApiFuture> listFuture = client.listTablesAsync();
+ * ApiFuture> listFuture = client.listTables();
*
* ApiFutures.addCallback(
* listFuture,
- * new ApiFutureCallback>() {
- * public void onSuccess(List tableNames) {
+ * new ApiFutureCallback>() {
+ * public void onSuccess(List tableIds) {
* System.out.println("Got list of tables:");
- * for (TableName name : tableNames) {
- * System.out.println(name.getTable());
+ * for (String tableId : tableIds) {
+ * System.out.println(tableId);
* }
* }
*
@@ -490,9 +489,8 @@ public List listTables() {
* );
* }
*/
- // TODO(igorbernstein2): consider changing this method to use relative table ids.
@SuppressWarnings("WeakerAccess")
- public ApiFuture> listTablesAsync() {
+ public ApiFuture> listTablesAsync() {
ListTablesRequest request = ListTablesRequest.newBuilder().setParent(instanceName.toString())
.build();
@@ -543,12 +541,12 @@ public ApiFuture> apply(
// Wrap all of the accumulated protos.
return ApiFutures.transform(allProtos,
- new ApiFunction, List>() {
+ new ApiFunction, List>() {
@Override
- public List apply(List protos) {
- List results = Lists.newArrayListWithCapacity(protos.size());
+ public List apply(List protos) {
+ List results = Lists.newArrayListWithCapacity(protos.size());
for (com.google.bigtable.admin.v2.Table proto : protos) {
- results.add(TableName.parse(proto.getName()));
+ results.add(TableName.parse(proto.getName()).getTable());
}
return results;
}
diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java
index 23f6f400bfce..b171386146fb 100644
--- a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java
+++ b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/BigtableTableAdminClientTest.java
@@ -248,12 +248,12 @@ public void testListTables() {
);
// Execute
- List actualResults = adminClient.listTables();
+ List actualResults = adminClient.listTables();
// Verify
- List expectedResults = Lists.newArrayList();
+ List expectedResults = Lists.newArrayList();
for (com.google.bigtable.admin.v2.Table expectedProto : expectedProtos) {
- expectedResults.add(TableName.parse(expectedProto.getName()));
+ expectedResults.add(TableName.parse(expectedProto.getName()).getTable());
}
assertThat(actualResults).containsExactlyElementsIn(expectedResults);
diff --git a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java
index ba64eaa3d712..96d4f99083ee 100644
--- a/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java
+++ b/google-cloud-clients/google-cloud-bigtable-admin/src/test/java/com/google/cloud/bigtable/admin/v2/it/BigtableTableAdminClientIT.java
@@ -22,7 +22,6 @@
import static org.junit.Assert.assertTrue;
import com.google.bigtable.admin.v2.InstanceName;
-import com.google.bigtable.admin.v2.TableName;
import com.google.cloud.bigtable.admin.v2.BigtableTableAdminClient;
import com.google.cloud.bigtable.admin.v2.models.ColumnFamily;
import com.google.cloud.bigtable.admin.v2.models.CreateTableRequest;
@@ -68,9 +67,9 @@ public static void createClient() throws IOException {
// Cleanup old tables, under normal circumstances this will do nothing
String stalePrefix = String.format("020%d", System.currentTimeMillis() - TimeUnit.DAYS.toMillis(1));
- for (TableName tableName : tableAdmin.listTables()) {
- if (stalePrefix.compareTo(tableName.getTable()) > 0) {
- tableAdmin.deleteTable(tableName.getTable());
+ for (String tableId: tableAdmin.listTables()) {
+ if (stalePrefix.compareTo(tableId) > 0) {
+ tableAdmin.deleteTable(tableId);
}
}
}
@@ -217,7 +216,7 @@ public void listTables() {
try {
tableAdmin.createTable(CreateTableRequest.of(tableId));
- List tables = tableAdmin.listTables();
+ List tables = tableAdmin.listTables();
assertNotNull(tables);
assertFalse("List tables did not return any tables", tables.isEmpty());
} finally {
@@ -231,7 +230,7 @@ public void listTablesAsync() throws Exception {
try {
tableAdmin.createTable(CreateTableRequest.of(tableId));
- List tables = tableAdmin.listTablesAsync().get();
+ List tables = tableAdmin.listTablesAsync().get();
assertNotNull(tables);
assertFalse("List tables did not return any tables", tables.isEmpty());
} finally {