Close service instance in Logging snippets (#1118)

Author: mziccard

gcloud-java-examples/src/main/java/com/google/cloud/examples/logging/snippets/CreateAndListMetrics.java

@@ -33,22 +33,23 @@
  */
 public class CreateAndListMetrics {
 
-  public static void main(String... args) {
+  public static void main(String... args) throws Exception {
     // Create a service object
     // Credentials are inferred from the environment
-    Logging logging = LoggingOptions.defaultInstance().service();
+    try(Logging logging = LoggingOptions.defaultInstance().service()) {
 
-    // Create a metric
-    MetricInfo metricInfo = MetricInfo.builder("test-metric", "severity >= ERROR")
-        .description("Log entries with severity higher or equal to ERROR")
-        .build();
-    logging.create(metricInfo);
+      // Create a metric
+      MetricInfo metricInfo = MetricInfo.builder("test-metric", "severity >= ERROR")
+          .description("Log entries with severity higher or equal to ERROR")
+          .build();
+      logging.create(metricInfo);
 
-    // List metrics
-    Page<Metric> metrics = logging.listMetrics();
-    Iterator<Metric> metricIterator = metrics.iterateAll();
-    while (metricIterator.hasNext()) {
-      System.out.println(metricIterator.next());
+      // List metrics
+      Page<Metric> metrics = logging.listMetrics();
+      Iterator<Metric> metricIterator = metrics.iterateAll();
+      while (metricIterator.hasNext()) {
+        System.out.println(metricIterator.next());
+      }
     }
   }
 }

gcloud-java-examples/src/main/java/com/google/cloud/examples/logging/snippets/CreateAndListSinks.java

@@ -33,22 +33,23 @@
  */
 public class CreateAndListSinks {
 
-  public static void main(String... args) {
+  public static void main(String... args) throws Exception {
     // Create a service object
     // Credentials are inferred from the environment
-    Logging logging = LoggingOptions.defaultInstance().service();
+    try(Logging logging = LoggingOptions.defaultInstance().service()) {
 
-    // Create a sink to back log entries to a BigQuery dataset
-    SinkInfo sinkInfo = SinkInfo.builder("test-sink", DatasetDestination.of("test-dataset"))
-        .filter("severity >= ERROR")
-        .build();
-    logging.create(sinkInfo);
+      // Create a sink to back log entries to a BigQuery dataset
+      SinkInfo sinkInfo = SinkInfo.builder("test-sink", DatasetDestination.of("test-dataset"))
+          .filter("severity >= ERROR")
+          .build();
+      logging.create(sinkInfo);
 
-    // List sinks
-    Page<Sink> sinks = logging.listSinks();
-    Iterator<Sink> sinkIterator = sinks.iterateAll();
-    while (sinkIterator.hasNext()) {
-      System.out.println(sinkIterator.next());
+      // List sinks
+      Page<Sink> sinks = logging.listSinks();
+      Iterator<Sink> sinkIterator = sinks.iterateAll();
+      while (sinkIterator.hasNext()) {
+        System.out.println(sinkIterator.next());
+      }
     }
   }
 }

gcloud-java-examples/src/main/java/com/google/cloud/examples/logging/snippets/WriteAndListLogEntries.java

@@ -35,27 +35,28 @@
  */
 public class WriteAndListLogEntries {
 
-  public static void main(String... args) {
+  public static void main(String... args) throws Exception {
     // Create a service object
     // Credentials are inferred from the environment
     LoggingOptions options = LoggingOptions.defaultInstance();
-    Logging logging = options.service();
+    try(Logging logging = options.service()) {
 
-    // Create a log entry
-    LogEntry firstEntry = LogEntry.builder(StringPayload.of("message"))
-        .logName("test-log")
-        .resource(MonitoredResource.builder("global")
-            .addLabel("project_id", options.projectId())
-            .build())
-        .build();
-    logging.write(Collections.singleton(firstEntry));
+      // Create a log entry
+      LogEntry firstEntry = LogEntry.builder(StringPayload.of("message"))
+          .logName("test-log")
+          .resource(MonitoredResource.builder("global")
+              .addLabel("project_id", options.projectId())
+              .build())
+          .build();
+      logging.write(Collections.singleton(firstEntry));
 
-    // List log entries
-    Page<LogEntry> entries = logging.listLogEntries(
-        EntryListOption.filter("logName=projects/" + options.projectId() + "/logs/test-log"));
-    Iterator<LogEntry> entryIterator = entries.iterateAll();
-    while (entryIterator.hasNext()) {
-      System.out.println(entryIterator.next());
+      // List log entries
+      Page<LogEntry> entries = logging.listLogEntries(
+          EntryListOption.filter("logName=projects/" + options.projectId() + "/logs/test-log"));
+      Iterator<LogEntry> entryIterator = entries.iterateAll();
+      while (entryIterator.hasNext()) {
+        System.out.println(entryIterator.next());
+      }
     }
   }
 }