Skip to content

Conversation

@vchudnov-g
Copy link
Contributor

No description provided.

@vchudnov-g vchudnov-g added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 12, 2022
@vchudnov-g vchudnov-g requested review from a team as code owners August 12, 2022 00:18
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 12, 2022
@vchudnov-g vchudnov-g marked this pull request as draft August 12, 2022 00:18
@vchudnov-g vchudnov-g force-pushed the numeric-enums-param branch from 35f1b84 to d9b2af5 Compare August 12, 2022 17:04
@vchudnov-g vchudnov-g force-pushed the numeric-enums-param branch from d9b2af5 to f0072a7 Compare August 12, 2022 17:07
@vchudnov-g vchudnov-g removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 12, 2022
@vchudnov-g vchudnov-g requested a review from parthea August 12, 2022 17:25
@vchudnov-g vchudnov-g marked this pull request as ready for review August 12, 2022 17:26
@vchudnov-g
Copy link
Contributor Author

@parthea LMK where would be a good place to test this using our existing framework. IMO, the best place would be an integration test against Showcase, but we're still building that framework.

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2022
@vchudnov-g vchudnov-g merged commit 63599bb into googleapis:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants