feat: prevent body double-read in googleapi.CheckResponse#1602
feat: prevent body double-read in googleapi.CheckResponse#1602codyoss merged 3 commits intogoogleapis:mainfrom
Conversation
|
Setting |
|
This is waiting on googleapis/google-api-go-client#2965, at which point https://pkg.go.dev/google.golang.org/api/googleapi should list |
|
@quartzmo do I need to update the go.mod in the showcase to point at the 0.218.0 release of Edited to add: based on the failure in the integration tests output, I think the answer is yes, so I've pushed a change to include that chore. |
|
Looks like we need to add a new leakchecker skip. maybe |
|
@bjohnso5 Thank you for all your work on these contributions! We will get our generator updated. I expect the new code won't land until early next week though just FYI. |
🤖 I have created a release *beep* *boop* --- ## [0.51.0](https://togithub.com/googleapis/gapic-generator-go/compare/v0.50.0...v0.51.0) (2025-01-24) ### Features * Prevent body double-read in googleapi.CheckResponse ([#1602](https://togithub.com/googleapis/gapic-generator-go/issues/1602)) ([bd42bc4](https://togithub.com/googleapis/gapic-generator-go/commit/bd42bc4f8818ef755ecdd05d7cedc2ac6b1bf8da)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Call into non-reading variant of CheckResponse added here.
Fixes googleapis/google-cloud-go#11458 (part 2 of 2).