chore: start running ci for node 10 (#729)

PR-URL: #729

Author: kjin

.circleci/config.yml

@@ -97,6 +97,7 @@ workflows:
       - node6
       - node8
       - node9
+      - node10
   tests:
     jobs:
       - node4:
@@ -107,12 +108,15 @@ workflows:
           filters: *release_tags
       - node9:
           filters: *release_tags
+      - node10:
+          filters: *release_tags
       - publish_npm:
           requires:
             - node4
             - node6
             - node8
             - node9
+            - node10
           filters:
             branches:
               ignore: /.*/
@@ -155,6 +159,15 @@ jobs:
       - *postgres_service
       - *mysql_service
     <<: *unit_tests
+  node10:
+    docker:
+      - image: node:10
+        environment: *test_env
+      - *mongo_service
+      - *redis_service
+      - *postgres_service
+      - *mysql_service
+    <<: *unit_tests
   publish_npm:
     docker:
       - image: node:8

appveyor.yml

@@ -5,6 +5,7 @@ environment:
   - nodejs_version: "4"
   - nodejs_version: "6"
   - nodejs_version: "8"
+  - nodejs_version: "10"
 
 cache:
   - src/plugins/types -> src/plugins/types/index.d.ts

bin/docker-trace.sh

@@ -4,7 +4,7 @@ if [ ! -z $1 ]; then
   if [ $COMMAND = 'start' ]; then
     docker run --name trace-test-mongo -p 127.0.0.1:27017:27017 -d mongo &&\
     docker run --name trace-test-redis -p 127.0.0.1:6379:6379 -d redis &&\
-    docker run --name trace-test-mysql -p 127.0.0.1:3306:3306 -e MYSQL_ROOT_PASSWORD='Password12!' -e MYSQL_DATABASE=test -d mysql
+    docker run --name trace-test-mysql -p 127.0.0.1:3306:3306 -e MYSQL_ROOT_PASSWORD='Password12!' -e MYSQL_DATABASE=test -d mysql:5
     docker run --name trace-test-postgres -p 127.0.0.1:5432:5432 -e POSTGRES_USER=postgres -e POSTGRES_PASSWORD='Password12!' -e POSTGRES_DB=test -d postgres
     exit $?
   elif [ $COMMAND = 'stop' ]; then

package-lock.json

@@ -59,7 +59,7 @@
     "@types/mocha": "^5.0.0",
     "@types/ncp": "^2.0.1",
     "@types/nock": "^9.1.2",
-    "@types/node": "^9.4.6",
+    "@types/node": "^10.0.0",
     "@types/once": "^1.4.0",
     "@types/pify": "^3.0.0",
     "@types/proxyquire": "^1.3.28",

package.json

@@ -1,29 +1,46 @@
 import * as path from 'path';
 import { globP, ncpP, spawnP, tmpDirP } from './utils';
 
+/**
+ * Get the major version number of the current Node process.
+ */
+function getNodeMajorVersion() {
+  return Number(process.version.slice(1).split('.')[0]);
+}
+
 /**
  * This function checks that the following two (sequential) operations succeed:
  * 1. In a temporary directory, installs from the `npm pack` of this directory
  * 2. Compiles a top-level file in that directory that imports this module
  */
 export async function checkInstall() {
-  // This script assumes that you don't already have a TGZ file
-  // in your current working directory.
+  // Determine a temporary directory in which this package should be installed.
   const installDir = await tmpDirP();
   console.log(installDir);
+  // Create a tgz with package contents using npm pack
   await spawnP('npm', ['pack']);
+  // Try to figure out the name of the tgz file that was just craeted
+  // This assumes that you don't already have a TGZ file
+  // in your current working directory.
   const tgz = await globP(`${process.cwd()}/*.tgz`);
   if (tgz.length !== 1) {
     throw new Error(`Expected 1 tgz file in current directory, but found ${tgz.length}`);
   }
+  // Initialize a new npm package.json in the temp directory.
   await spawnP('npm', ['init', '-y'], {
     cwd: installDir
   });
-  await spawnP('npm', ['install', 'typescript', '@types/node', tgz[0]], {
+  // Install the tgz file as a package, along with necessities.
+  // @types/node version should match the current process version, but clamped
+  // at >=9 (because of http2 types).
+  const nodeTypesVersion = Math.max(getNodeMajorVersion(), 9);
+  await spawnP('npm', ['install', 'typescript', `@types/node@${nodeTypesVersion}`, tgz[0]], {
     cwd: installDir
   });
+  // Create an entry point for the package created in the temp directory
   // use-module.ts is a fixture that imports the Trace Agent
   await ncpP('./test/fixtures/use-module.ts', `${installDir}/index.ts`);
+  // Compile it
   await spawnP(`node_modules${path.sep}.bin${path.sep}tsc`, ['index.ts'], {
     cwd: installDir
   });