From 8243b9a316f53445cdd251a974a0fdc107b8efdc Mon Sep 17 00:00:00 2001 From: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Date: Wed, 28 Jul 2021 15:49:35 -0600 Subject: [PATCH] Expand `google-api-core pin` to `>1, <3` To avoid diamond dependency conflicts with Cloud libraries, the Ads library should keep a `>1, <3` pin on google-api-core until https://github.com/googleapis/google-cloud-python/issues/10566 is closed. See discussion in [doc](https://docs.google.com/document/d/1euAvUsia_4zf98lNvpwA3K0o2b4y5Xr9xAkyzCnIMzQ/edit#). --- setup.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 39d798308..81ca6c794 100644 --- a/setup.py +++ b/setup.py @@ -18,7 +18,10 @@ install_requires = [ "google-auth-oauthlib >= 0.3.0, < 1.0.0", - "google-api-core >= 1.21.0, < 2.0.0", + # NOTE: Maintainers, please do not require google-api-core>=2.x.x + # Until this issue is closed + # https://github.com/googleapis/google-cloud-python/issues/10566 + "google-api-core >= 1.21.0, < 3.0.0", "googleapis-common-protos >= 1.5.8, < 2.0.0", "grpcio >= 1.38.1, < 2.0.0", "proto-plus >= 1.18.0, < 2.0.0",