Add missing test_descr_src_loc in CMakeLists.txt (#30137)

* Add missing (for a long time) `test_descr_src_loc` to CMakeLists.txt

* Fix bug in test_descr_src_loc.cpp: `!defined(PYBIND11_DETAIL_UNDERSCORE_BACKWARD_COMPATIBILITY)`

* Disable `type_caster` ODR guard for CUDACC and NVCOMPILER: the missing `test_descr_src_loc` in tests/CMakeLists.txt masked that `src_loc` is not reliable.

* Fix ruff error (not sure why this passed when testing locally).

Author: rwgk

include/pybind11/detail/descr.h

@@ -42,9 +42,12 @@ PYBIND11_NAMESPACE_BEGIN(detail)
 // * MSVC 193732825 C++17 windows-2020 is failing for unknown reasons.
 // * Intel 2021.6.0.20220226 (g++ 9.4 mode) __builtin_LINE() is unreliable
 //   (line numbers vary between translation units).
+// * NVIDIA 12.2.140 (CUDACC) src_loc is unreliable for unknown reasons.
+// * NVHPC 23.5.0 (NVCOMPILER) src_loc is unreliable for unknown reasons.
 #if defined(PYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD_IF_AVAILABLE)                                   \
     && !defined(PYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD) && defined(PYBIND11_CPP17)                 \
-    && !defined(__INTEL_COMPILER)                                                                 \
+    && !defined(__INTEL_COMPILER) && !defined(__CUDACC_VER_MAJOR__)                               \
+    && !defined(__NVCOMPILER_MAJOR__)                                                             \
     && (!defined(_MSC_VER)                                                                        \
         || (_MSC_VER >= 1920 /* MSVC 2019 or newer */                                             \
             && (_MSC_FULL_VER < 193732825 || _MSC_FULL_VER > 193732826                            \

tests/CMakeLists.txt

@@ -151,6 +151,7 @@ set(PYBIND11_TEST_FILES
     test_copy_move
     test_custom_type_casters
     test_custom_type_setup
+    test_descr_src_loc
     test_docstring_options
     test_eigen_matrix
     test_eigen_tensor

tests/test_descr_src_loc.cpp

@@ -110,6 +110,11 @@ TEST_SUBMODULE(descr_src_loc, m) {
     ATTR_BLKC(block_const_name, c6)
     ATTR_BLKC(block_const_name, c7)
 
+    m.attr("defined_PYBIND11_DETAIL_UNDERSCORE_BACKWARD_COMPATIBILITY") =
+#    if !defined(PYBIND11_DETAIL_UNDERSCORE_BACKWARD_COMPATIBILITY)
+        false;
+#    else
+        true;
     ATTR_OFFS(block_underscore)
     ATTR_BLKC(block_underscore, c0)
     ATTR_BLKC(block_underscore, c1)
@@ -119,6 +124,7 @@ TEST_SUBMODULE(descr_src_loc, m) {
     ATTR_BLKC(block_underscore, c5)
     ATTR_BLKC(block_underscore, c6)
     ATTR_BLKC(block_underscore, c7)
+#    endif
 
     ATTR_OFFS(block_plus)
     ATTR_BLKC(block_plus, c0)

tests/test_descr_src_loc.py

@@ -45,6 +45,11 @@
 @pytest.mark.skipif(m.block_descr_offset is None, reason="Not enabled.")
 @pytest.mark.parametrize(("block_name", "expected_text_line"), block_parametrize)
 def test_block(block_name, expected_text_line):
+    if (
+        block_name == "block_underscore"
+        and not m.defined_PYBIND11_DETAIL_UNDERSCORE_BACKWARD_COMPATIBILITY
+    ):
+        pytest.skip("!defined(PYBIND11_DETAIL_UNDERSCORE_BACKWARD_COMPATIBILITY)")
     offset = getattr(m, f"{block_name}_offset")
     for ix, (expected_text, expected_line) in enumerate(expected_text_line):
         text, file, line = getattr(m, f"{block_name}_c{ix}")

tests/test_type_caster_odr_guard_1.cpp

@@ -82,19 +82,4 @@ TEST_SUBMODULE(type_caster_odr_guard_1, m) {
 #else
         false;
 #endif
-
-    m.attr("CUDACC") =
-#if defined(__CUDACC_VER_MAJOR__)
-        PYBIND11_TOSTRING(__CUDACC_VER_MAJOR__) "." PYBIND11_TOSTRING(
-            __CUDACC_VER_MINOR__) "." PYBIND11_TOSTRING(__CUDACC_VER_BUILD__);
-#else
-        py::none();
-#endif
-    m.attr("NVCOMPILER") =
-#if defined(__NVCOMPILER_MAJOR__)
-        PYBIND11_TOSTRING(__NVCOMPILER_MAJOR__) "." PYBIND11_TOSTRING(
-            __NVCOMPILER_MINOR__) "." PYBIND11_TOSTRING(__NVCOMPILER_PATCHLEVEL__);
-#else
-        py::none();
-#endif
 }

tests/test_type_caster_odr_guard_1.py

@@ -45,11 +45,6 @@ def test_type_caster_odr_violation_detected_counter():
     num_violations = m.type_caster_odr_violation_detected_count()
     if num_violations is None:
         pytest.skip("type_caster_odr_violation_detected_count() is None")
-    if num_violations == 0:
-        if m.if_defined__NO_INLINE__:
-            pytest.skip(_count_0_message("__NO_INLINE__"))
-        if m.CUDACC is not None:
-            pytest.skip(_count_0_message(f"CUDACC = {m.CUDACC}"))
-        if m.NVCOMPILER is not None:
-            pytest.skip(_count_0_message(f"NVCOMPILER = {m.NVCOMPILER}"))
+    if num_violations == 0 and m.if_defined__NO_INLINE__:
+        pytest.skip(_count_0_message("__NO_INLINE__"))
     assert num_violations == 1