ui: Fetch distinct values for equality #3817
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-19678478973-ui/ui/index.html |
stevegolton
requested changes
Nov 24, 2025
| const MAX_DISPLAY_STRING_LENGTH = 50; | ||
| const SEARCH_BOX_THRESHOLD = 10; | ||
|
|
||
| interface DistinctValuesFilterMenuAttrs { |
Member
There was a problem hiding this comment.
This is subjective but this component feels a bit too interested in its parent state. Maybe it would be better off as a render() function inside the main DataGrid component so you're having to do a lot of prop drilling.
aMayzner
force-pushed
the
dev/mayzner/datagrid-distinct
branch
from
808f36f to
6161e51
Compare
auto-merge was automatically disabled
November 28, 2025 18:17
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for filtering data grid columns by selecting from distinct values. The feature adds "Filter equal to..." and "Filter not equal to..." menu items that fetch and display up to 100 distinct values from the current dataset. The menu includes a search box for columns with many values and respects existing filters/sorting.
Changes
getDistinctValues()method toDataGridDataSourceinterfacegetDistinctValues()in bothSQLDataSourceandInMemoryDataSourceDistinctValuesFilterMenucomponent with search, loading states, and value cachingcompareSqlValues()utility function for consistent sorting across datagrid codebase