test: include groups when describing package details (#933)

G-Rath · web-flow · commit d75f136bbfdf · 2024-04-23T13:44:53.000+10:00
Ran into this while working on other stuff - currently if two packages
are the same except for their groups, the failure message doesn't
indicate that which is confusing
diff --git a/pkg/lockfile/helpers_test.go b/pkg/lockfile/helpers_test.go
@@ -42,7 +42,13 @@ func packageToString(pkg lockfile.PackageDetails) string {
 		commit = "<no commit>"
 	}
 
-	return fmt.Sprintf("%s@%s (%s, %s)", pkg.Name, pkg.Version, pkg.Ecosystem, commit)
+	groups := strings.Join(pkg.DepGroups, ", ")
+
+	if groups == "" {
+		groups = "<no groups>"
+	}
+
+	return fmt.Sprintf("%s@%s (%s, %s, %s)", pkg.Name, pkg.Version, pkg.Ecosystem, commit, groups)
 }
 
 func hasPackage(t *testing.T, packages []lockfile.PackageDetails, pkg lockfile.PackageDetails) bool {

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,13 @@ func packageToString(pkg lockfile.PackageDetails) string {`
`42`	`42`	`commit = "<no commit>"`
`43`	`43`	`}`
`44`	`44`
`45`		`- return fmt.Sprintf("%s@%s (%s, %s)", pkg.Name, pkg.Version, pkg.Ecosystem, commit)`
	`45`	`+ groups := strings.Join(pkg.DepGroups, ", ")`
	`46`	`+`
	`47`	`+ if groups == "" {`
	`48`	`+ groups = "<no groups>"`
	`49`	`+ }`
	`50`	`+`
	`51`	`+ return fmt.Sprintf("%s@%s (%s, %s, %s)", pkg.Name, pkg.Version, pkg.Ecosystem, commit, groups)`
`46`	`52`	`}`
`47`	`53`
`48`	`54`	`func hasPackage(t *testing.T, packages []lockfile.PackageDetails, pkg lockfile.PackageDetails) bool {`