Skip to content

Commit c6dba9b

Browse files
klueverGoogle Java Core Libraries
authored andcommitted
Add fixes in prep for enabling CheckReturnValue on constructors.
RELNOTES=n/a PiperOrigin-RevId: 422573390
1 parent a4fabc0 commit c6dba9b

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

android/guava-tests/test/com/google/common/collect/RegularImmutableAsListTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ public class RegularImmutableAsListTest extends TestCase {
3030
*/
3131
public void testDoesntCheckForNull() {
3232
ImmutableSet<Integer> set = ImmutableSet.of(1, 2, 3);
33-
new RegularImmutableAsList<Integer>(set, new Object[] {null, null, null});
33+
ImmutableList<Integer> unused =
34+
new RegularImmutableAsList<Integer>(set, new Object[] {null, null, null});
3435
// shouldn't throw!
3536
}
3637
}

android/guava-tests/test/com/google/common/reflect/InvokableTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ public void run() {
601601
}
602602

603603
public void testAnonymousClassInConstructor() {
604-
new AnonymousClassInConstructor();
604+
AnonymousClassInConstructor unused = new AnonymousClassInConstructor();
605605
}
606606

607607
private static class AnonymousClassInConstructor {
@@ -621,7 +621,7 @@ public void run() {
621621
}
622622

623623
public void testLocalClassInInstanceInitializer() {
624-
new LocalClassInInstanceInitializer();
624+
LocalClassInInstanceInitializer unused = new LocalClassInInstanceInitializer();
625625
}
626626

627627
private static class LocalClassInInstanceInitializer {
@@ -633,7 +633,7 @@ class Local {}
633633
}
634634

635635
public void testLocalClassInStaticInitializer() {
636-
new LocalClassInStaticInitializer();
636+
LocalClassInStaticInitializer unused = new LocalClassInStaticInitializer();
637637
}
638638

639639
private static class LocalClassInStaticInitializer {
@@ -645,7 +645,8 @@ class Local {}
645645
}
646646

647647
public void testLocalClassWithSeeminglyHiddenThisInStaticInitializer_BUG() {
648-
new LocalClassWithSeeminglyHiddenThisInStaticInitializer();
648+
LocalClassWithSeeminglyHiddenThisInStaticInitializer unused =
649+
new LocalClassWithSeeminglyHiddenThisInStaticInitializer();
649650
}
650651

651652
/**

guava-tests/test/com/google/common/collect/RegularImmutableAsListTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ public class RegularImmutableAsListTest extends TestCase {
3030
*/
3131
public void testDoesntCheckForNull() {
3232
ImmutableSet<Integer> set = ImmutableSet.of(1, 2, 3);
33-
new RegularImmutableAsList<Integer>(set, new Object[] {null, null, null});
33+
ImmutableList<Integer> unused =
34+
new RegularImmutableAsList<Integer>(set, new Object[] {null, null, null});
3435
// shouldn't throw!
3536
}
3637
}

guava-tests/test/com/google/common/reflect/InvokableTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ public void run() {
601601
}
602602

603603
public void testAnonymousClassInConstructor() {
604-
new AnonymousClassInConstructor();
604+
AnonymousClassInConstructor unused = new AnonymousClassInConstructor();
605605
}
606606

607607
private static class AnonymousClassInConstructor {
@@ -621,7 +621,7 @@ public void run() {
621621
}
622622

623623
public void testLocalClassInInstanceInitializer() {
624-
new LocalClassInInstanceInitializer();
624+
LocalClassInInstanceInitializer unused = new LocalClassInInstanceInitializer();
625625
}
626626

627627
private static class LocalClassInInstanceInitializer {
@@ -633,7 +633,7 @@ class Local {}
633633
}
634634

635635
public void testLocalClassInStaticInitializer() {
636-
new LocalClassInStaticInitializer();
636+
LocalClassInStaticInitializer unused = new LocalClassInStaticInitializer();
637637
}
638638

639639
private static class LocalClassInStaticInitializer {
@@ -645,7 +645,8 @@ class Local {}
645645
}
646646

647647
public void testLocalClassWithSeeminglyHiddenThisInStaticInitializer_BUG() {
648-
new LocalClassWithSeeminglyHiddenThisInStaticInitializer();
648+
LocalClassWithSeeminglyHiddenThisInStaticInitializer unused =
649+
new LocalClassWithSeeminglyHiddenThisInStaticInitializer();
649650
}
650651

651652
/**

0 commit comments

Comments
 (0)