Skip to content

Conversation

@hsubox76
Copy link
Collaborator

@hsubox76 hsubox76 commented May 9, 2024

A bug in the logic caused the FileMetadata.name field to be filled with files/undefined instead of actually being left undefined when the user does not provide that value.

@hsubox76 hsubox76 marked this pull request as ready for review May 9, 2024 16:25
@hsubox76 hsubox76 requested a review from lahirumaramba May 9, 2024 16:26
Copy link
Collaborator

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hsubox76 hsubox76 merged commit 819501f into main May 9, 2024
@hsubox76 hsubox76 deleted the ch-filename-bugfix branch May 9, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants