Skip to content

Fix a couple bugs where not all params are passed through to the request #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hsubox76 merged 3 commits into from
Apr 16, 2024
Merged

Fix a couple bugs where not all params are passed through to the request #103

hsubox76 merged 3 commits into from
Apr 16, 2024

Conversation

@hsubox76
Copy link
Collaborator

@hsubox76 hsubox76 commented Apr 16, 2024

Fixed bugs where

  • RequestOptions was not passed to countTokens and embedContent
  • generationConfig and safetySettings were not passed through startChat to ChatSession.

Fixes #101
Fixes #98

@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 6724e42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@google/generative-ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review April 16, 2024 01:27
@hsubox76 hsubox76 requested a review from lahirumaramba April 16, 2024 16:12
lahirumaramba
lahirumaramba approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hsubox76 hsubox76 merged commit 6ef8cee into main Apr 16, 2024
@hsubox76 hsubox76 deleted the ch-param-bugs branch April 16, 2024 17:55
@Anomaly-1 Anomaly-1 mentioned this pull request May 20, 2024
Open
@gaohongwei11 gaohongwei11 mentioned this pull request May 25, 2024
Open
@Anomaly-1 Anomaly-1 mentioned this pull request May 25, 2024
Open
@gaohongwei11 gaohongwei11 mentioned this pull request May 25, 2024
Open
@patooworld patooworld mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

@hsubox76 hsubox76

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ChatSession don't inherit generationConfig from GenerativeModel Request options are not passed to modelInstance.countTokens

2 participants

@hsubox76 @lahirumaramba