Skip to content

Commit 066fd13

Browse files
committed
internal/telemetry/event: fix error/value key type tag formatting
%v behaves better with nil values. Change-Id: I4041f5460173c8f420553996d64d9463ef5a0370 Reviewed-on: https://go-review.googlesource.com/c/tools/+/227355 Run-TryBot: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Robert Findley <[email protected]>
1 parent 1fd9766 commit 066fd13

File tree

1 file changed

+2
-2
lines changed
  • internal/telemetry/event

1 file changed

+2
-2
lines changed

internal/telemetry/event/tag.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,9 @@ func (t Tag) Format(f fmt.State, r rune) {
106106
case *StringKey:
107107
fmt.Fprintf(f, "%s=%q", key.Name(), key.From(t))
108108
case *ErrorKey:
109-
fmt.Fprintf(f, "%s=%q", key.Name(), key.From(t))
109+
fmt.Fprintf(f, "%s=%v", key.Name(), key.From(t))
110110
case *ValueKey:
111-
fmt.Fprintf(f, "%s=%q", key.Name(), key.From(t))
111+
fmt.Fprintf(f, "%s=%v", key.Name(), key.From(t))
112112
default:
113113
fmt.Fprintf(f, `%s="invalid type %T"`, key.Name(), key)
114114
}

0 commit comments

Comments
 (0)