Make RetrieveToken usable by client packages

[mholt]

I'm working on a client that needs to refresh tokens in a special way, so I'm implementing my own TokenSource. The strange thing seems to be that, although the TokenSource interface is exported, I can't actually reuse the provided logic to refresh a token, as retrieveToken is unexported and it calls an internal-only function: internal.RetrieveToken(), even though all the parameters are exported values too.

oauth2/token.go

Line 154 in c453e0c

tk, err := internal.RetrieveToken(ctx, c.ClientID, c.ClientSecret, c.Endpoint.TokenURL, v)

I'd like to use either retrieveToken() or internal.RetrieveToken() as I'm essentially wrapping it differently than the built-in token refresher.

Can we potentially export retrieveToken() or make internal.RetrieveToken() usable by external packages?

[mholt]

Figured out another way to do this in the meantime

[pacoguzman]

I'm trying to do something similar, what was your way to do it if you can share it?

[mholt]

Uhhh wow, 5 years ago, I don't really remember 😅

I think I was working on this project at the time, so you may find some hints in this file: https://github.com/mholt/timeliner/blob/cf155164e218ca1ad6ad600152cd2436c88dba43/oauth2.go#L41 -- not 100% sure it worked correctly but I think it did work for me. 🤷‍♂️

[pacoguzman]

Thank you for your response, I've reused existing API and write some comments about it to my future self.

…

On Tue, Jun 6, 2023, 18:28 Matt Holt ***@***.***> wrote: Reopened #354 <#354>. — Reply to this email directly, view it on GitHub <#354 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACVLV6FX5UREKULX3GUQTXJ5LDLANCNFSM4GLRKGVQ> . You are receiving this because you commented.Message ID: ***@***.***>