Skip to content

Conversation

@DeeJayLSP
Copy link
Contributor

@DeeJayLSP DeeJayLSP commented Nov 3, 2025

Applies the StyleBox from #112233 on signal and group subsections.

Before After
before_dark before_groups after_dark after_groups

Classic for comparison:
classic

@DeeJayLSP DeeJayLSP requested a review from a team as a code owner November 3, 2025 23:26
@DeeJayLSP

This comment was marked as resolved.

@YeldhamDev
Copy link
Member

I hope we don't end up with several instances of this workaround in the code, otherwise it would be better to just deprecate the BG color element and introduce the stylebox properly in Tree.

@DeeJayLSP
Copy link
Contributor Author

DeeJayLSP commented Nov 3, 2025

I hope we don't end up with several instances of this workaround in the code, otherwise it would be better to just deprecate the BG color element and introduce the stylebox properly in Tree.

Apart from the ones covered in this PR and the Action Map editor, there are no more than 3 places left for it to be used.

@DeeJayLSP DeeJayLSP force-pushed the more-prop-subsection branch from eb5f661 to 2df90ee Compare November 4, 2025 00:25
@DeeJayLSP DeeJayLSP requested review from a team as code owners November 4, 2025 00:25
@passivestar
Copy link
Contributor

Looks good although I do have a concern that they don't bring enough value to justify a bit of extra noise they add to the dock, considering they are simple trees and node/signal separation is already somewhat prominent from indentation and repeating signal icons, and groups only have 2 categories in them. The input map tree from #112233 is different because stripes help match buttons to their rows in it

It might be worth thinking if this is worth copying from the classic theme, but it's a small change so I won't die on this hill

On a sidenote it might be worth considering how this gonna go with alternating stripes if those are added to trees

@DeeJayLSP
Copy link
Contributor Author

it would be better to just deprecate the BG color element and introduce the stylebox properly in Tree.

Just opened #112371

@DeeJayLSP DeeJayLSP marked this pull request as draft November 5, 2025 19:03
@DeeJayLSP
Copy link
Contributor Author

Marking as draft until #112444 is merged in order to make things simpler.

@DeeJayLSP DeeJayLSP force-pushed the more-prop-subsection branch from 2df90ee to 5c4d993 Compare November 7, 2025 19:23
@DeeJayLSP DeeJayLSP marked this pull request as ready for review November 7, 2025 19:23
@DeeJayLSP
Copy link
Contributor Author

DeeJayLSP commented Nov 7, 2025

Modified so now it doesn't use the workaround anymore. Screenshots updated.

Despite this being kinda divisive, I still want to see if more people wants it

(This is probably the last place I'll push for this highlight, as stuff that used prop_subsection apart from this and the action map editor didn't look good).

Looks good although I do have a concern that they don't bring enough value to justify a bit of extra noise they add to the dock.

One could argue that the node types in the Inspector tab do have highlights (which isn't changed in the Modern theme), so this would be just spreading it to the Node tab:

image

(Not sure if this is a valid comparison since the tone is different)

@Repiteo Repiteo merged commit 2ab796b into godotengine:master Nov 10, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 10, 2025

Thanks!

@DeeJayLSP DeeJayLSP deleted the more-prop-subsection branch November 10, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants