-
-
Notifications
You must be signed in to change notification settings - Fork 23.6k
Modern Style: Use a StyleBox in signals and groups #112360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
I hope we don't end up with several instances of this workaround in the code, otherwise it would be better to just deprecate the BG color element and introduce the stylebox properly in |
Apart from the ones covered in this PR and the Action Map editor, there are no more than 3 places left for it to be used. |
eb5f661 to
2df90ee
Compare
|
Looks good although I do have a concern that they don't bring enough value to justify a bit of extra noise they add to the dock, considering they are simple trees and node/signal separation is already somewhat prominent from indentation and repeating signal icons, and groups only have 2 categories in them. The input map tree from #112233 is different because stripes help match buttons to their rows in it It might be worth thinking if this is worth copying from the classic theme, but it's a small change so I won't die on this hill On a sidenote it might be worth considering how this gonna go with alternating stripes if those are added to trees |
Just opened #112371 |
|
Marking as draft until #112444 is merged in order to make things simpler. |
2df90ee to
5c4d993
Compare
|
Thanks! |

Applies the StyleBox from #112233 on signal and group subsections.
Classic for comparison:
