Skip to content

Commit b4a6189

Browse files
melizecheBeryJu
andauthored
core: bump selenium from 4.31.0 to v4.32.0 (#14394)
* core: bump selenium from 4.31.0 to v4.32.0 * deal with selenium breaking stuff on minor versions SeleniumHQ/selenium#15641 Signed-off-by: Jens Langhammer <jens@goauthentik.io> * format Signed-off-by: Jens Langhammer <jens@goauthentik.io> --------- Signed-off-by: Jens Langhammer <jens@goauthentik.io> Co-authored-by: Jens Langhammer <jens@goauthentik.io>
1 parent bfdb827 commit b4a6189

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

tests/e2e/utils.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
from selenium.common.exceptions import NoSuchElementException, TimeoutException, WebDriverException
2727
from selenium.webdriver.common.by import By
2828
from selenium.webdriver.common.keys import Keys
29+
from selenium.webdriver.remote.command import Command
2930
from selenium.webdriver.remote.webdriver import WebDriver
3031
from selenium.webdriver.remote.webelement import WebElement
3132
from selenium.webdriver.support.wait import WebDriverWait
@@ -197,7 +198,12 @@ def tearDown(self):
197198
super().tearDown()
198199
if IS_CI:
199200
print("::group::Browser logs")
200-
for line in self.driver.get_log("browser"):
201+
# Very verbose way to get browser logs
202+
# https://github.com/SeleniumHQ/selenium/pull/15641
203+
# for some reason this removes the `get_log` API from Remote Webdriver
204+
# and only keeps it on the local Chrome web driver, even when using
205+
# a remote chrome driver...? (nvm the fact this was released as a minor version)
206+
for line in self.driver.execute(Command.GET_LOG, {"type": "browser"})["value"]:
201207
print(line["message"])
202208
if IS_CI:
203209
print("::endgroup::")

uv.lock

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)