From 3eecfba62a4153a946d57447176aa977a7d85e33 Mon Sep 17 00:00:00 2001 From: Jacob Floyd Date: Thu, 14 Apr 2022 12:03:14 -0500 Subject: [PATCH] refactor: drop duplicate executor.DestroyBuild call The duplicate DestroyBuild call causes a bunch of errors in the log about the build already being destroyed. So, let's just drop the duplicate call. --- cmd/vela-worker/exec.go | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/cmd/vela-worker/exec.go b/cmd/vela-worker/exec.go index f369c27c..984e31dd 100644 --- a/cmd/vela-worker/exec.go +++ b/cmd/vela-worker/exec.go @@ -108,6 +108,8 @@ func (w *Worker) exec(index int) error { if err != nil { logger.Errorf("unable to destroy build: %v", err) } + + logger.Info("completed build") }() logger.Info("creating build") @@ -142,14 +144,5 @@ func (w *Worker) exec(index int) error { return nil } - logger.Info("destroying build") - // destroy the build with the executor - err = _executor.DestroyBuild(context.Background()) - if err != nil { - logger.Errorf("unable to destroy build: %v", err) - } - - logger.Info("completed build") - return nil }