Merge branch 'master' into inspect-container-panic

Author: wass3r

executor/context_test.go

@@ -55,7 +55,7 @@ func TestExecutor_FromContext(t *testing.T) {
 		want    Engine
 	}{
 		{
-			// nolint: staticcheck // ignore using string with context value
+			// nolint: staticcheck,revive // ignore using string with context value
 			context: context.WithValue(context.Background(), key, _engine),
 			want:    _engine,
 		},
@@ -64,7 +64,7 @@ func TestExecutor_FromContext(t *testing.T) {
 			want:    nil,
 		},
 		{
-			// nolint: staticcheck // ignore using string with context value
+			// nolint: staticcheck,revive // ignore using string with context value
 			context: context.WithValue(context.Background(), key, "foo"),
 			want:    nil,
 		},
@@ -173,7 +173,7 @@ func TestExecutor_WithContext(t *testing.T) {
 		t.Errorf("unable to create linux engine: %v", err)
 	}
 
-	// nolint: staticcheck // ignore using string with context value
+	// nolint: staticcheck,revive // ignore using string with context value
 	want := context.WithValue(context.Background(), key, _engine)
 
 	// run test

mock/docker/docker.go

@@ -23,6 +23,7 @@ const Version = "v1.40"
 
 // New returns a client that is capable of handling
 // Docker client calls and returning stub responses.
+// nolint:revive // ignore unexported type as it is intentional
 func New() (*mock, error) {
 	return &mock{
 		ConfigService:       ConfigService{},

runtime/context_test.go

@@ -29,7 +29,7 @@ func TestRuntime_FromContext(t *testing.T) {
 		want    Engine
 	}{
 		{
-			// nolint: staticcheck // ignore using string with context value
+			// nolint: staticcheck,revive // ignore using string with context value
 			context: context.WithValue(context.Background(), key, _engine),
 			want:    _engine,
 		},
@@ -38,7 +38,7 @@ func TestRuntime_FromContext(t *testing.T) {
 			want:    nil,
 		},
 		{
-			// nolint: staticcheck // ignore using string with context value
+			// nolint: staticcheck,revive // ignore using string with context value
 			context: context.WithValue(context.Background(), key, "foo"),
 			want:    nil,
 		},
@@ -109,7 +109,7 @@ func TestRuntime_WithContext(t *testing.T) {
 		t.Errorf("unable to create runtime engine: %v", err)
 	}
 
-	// nolint: staticcheck // ignore using string with context value
+	// nolint: staticcheck,revive // ignore using string with context value
 	want := context.WithValue(context.Background(), key, _engine)
 
 	// run test

runtime/kubernetes/build.go

@@ -23,7 +23,7 @@ import (
 func (c *client) InspectBuild(ctx context.Context, b *pipeline.Build) ([]byte, error) {
 	c.Logger.Tracef("inspecting build pod for pipeline %s", b.ID)
 
-	output := []byte(fmt.Sprintf("> Inspecting pod for pipeline %s", b.ID))
+	output := []byte(fmt.Sprintf("> Inspecting pod for pipeline %s\n", b.ID))
 
 	// TODO: The environment gets populated in AssembleBuild, after InspectBuild runs.
 	//       But, we should make sure that secrets can't be leaked here anyway.

runtime/kubernetes/container.go

@@ -259,15 +259,8 @@ func (c *client) TailContainer(ctx context.Context, ctn *pipeline.Container) (io
 		//
 		// https://pkg.go.dev/k8s.io/api/core/v1?tab=doc#PodLogOptions
 		opts := &v1.PodLogOptions{
-			Container: ctn.ID,
-			Follow:    true,
-			// steps can exit quickly, and might be gone before
-			// log tailing has started, so we need to request
-			// logs for previously exited containers as well.
-			// Pods get deleted after job completion, and names for
-			// pod+container don't get reused. So, previous
-			// should only retrieve logs for the current build step.
-			Previous:   true,
+			Container:  ctn.ID,
+			Follow:     true,
 			Timestamps: false,
 		}