From 3f6461bcc402da92e267123bd86f0f1350c3e656 Mon Sep 17 00:00:00 2001 From: Frederic BIDON Date: Sun, 1 Mar 2026 17:44:39 +0100 Subject: [PATCH] fix: test reports upload should be conditioned by lint Signed-off-by: Frederic BIDON --- .github/workflows/TODO.md | 1 - .github/workflows/go-test-monorepo.yml | 2 +- .github/workflows/go-test.yml | 2 +- .github/workflows/prepare-release-monorepo.yml | 3 +++ 4 files changed, 5 insertions(+), 3 deletions(-) delete mode 100644 .github/workflows/TODO.md diff --git a/.github/workflows/TODO.md b/.github/workflows/TODO.md deleted file mode 100644 index 98f0137..0000000 --- a/.github/workflows/TODO.md +++ /dev/null @@ -1 +0,0 @@ -* collect-test-reports should only execute if lint is successful diff --git a/.github/workflows/go-test-monorepo.yml b/.github/workflows/go-test-monorepo.yml index 91663a1..aa7233a 100644 --- a/.github/workflows/go-test-monorepo.yml +++ b/.github/workflows/go-test-monorepo.yml @@ -232,5 +232,5 @@ jobs: collect-reports: needs: [test] - if: ${{ !cancelled() }} + if: ${{ !cancelled() && needs.test.result != 'skipped' }} uses: ./.github/workflows/collect-reports.yml diff --git a/.github/workflows/go-test.yml b/.github/workflows/go-test.yml index c39b8fe..c2dd1de 100644 --- a/.github/workflows/go-test.yml +++ b/.github/workflows/go-test.yml @@ -125,5 +125,5 @@ jobs: collect-reports: needs: [test] - if: ${{ !cancelled() }} + if: ${{ !cancelled() && needs.test.result != 'skipped' }} uses: ./.github/workflows/collect-reports.yml diff --git a/.github/workflows/prepare-release-monorepo.yml b/.github/workflows/prepare-release-monorepo.yml index 9e1f534..09323d1 100644 --- a/.github/workflows/prepare-release-monorepo.yml +++ b/.github/workflows/prepare-release-monorepo.yml @@ -148,6 +148,9 @@ jobs: # # In some situations, we may have a test dependency of a module on itself and this # case must be skipped. + # + # Caveat: if the module's author forgot to put a proper release (e.g. use pseudo-commit instead of + # proper vx.y.z require), this rewrite will be omitted. For now, this edge case is simply ignored. current_module=$(go list) while read -r module ; do echo "::notice title=updating-dependency::Updating ${module} to ${TARGET_TAG}"